From: Jiri Olsa <jolsa@redhat.com>
To: acme@redhat.com, a.p.zijlstra@chello.nl, mingo@elte.hu,
paulus@samba.org, cjashfor@linux.vnet.ibm.com,
fweisbec@gmail.com
Cc: linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@redhat.com>
Subject: [PATCH 1/3] perf, tool: Force guest machine definition option
Date: Thu, 12 Apr 2012 14:21:00 +0200 [thread overview]
Message-ID: <1334233262-5679-2-git-send-email-jolsa@redhat.com> (raw)
In-Reply-To: <1334233262-5679-1-git-send-email-jolsa@redhat.com>
Running 'perf kvm record' without any of following options:
--guestmount
--guestvmlinux
--guestkallsyms
--guestmodules
is causing the guest machine to be ommited from the data file,
and all guest samples are counted in nr_unprocessable_samples.
This patch makes sure the 'perf kvm record' command is not
let through until one of the above option is specified.
Signed-off-by: Jiri Olsa <jolsa@redhat.com>
---
tools/perf/builtin-kvm.c | 10 ++++++++++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/tools/perf/builtin-kvm.c b/tools/perf/builtin-kvm.c
index 9fc6e0f..559d468 100644
--- a/tools/perf/builtin-kvm.c
+++ b/tools/perf/builtin-kvm.c
@@ -53,6 +53,16 @@ static int __cmd_record(int argc, const char **argv)
int rec_argc, i = 0, j;
const char **rec_argv;
+ if (perf_guest &&
+ !(symbol_conf.guestmount ||
+ symbol_conf.default_guest_vmlinux_name ||
+ symbol_conf.default_guest_modules ||
+ symbol_conf.default_guest_kallsyms)) {
+ ui__warning("You need to define guest with one of guestmount|"
+ "guestvmlinux|guestkallsyms|guestmodules\n");
+ return -EINVAL;
+ }
+
rec_argc = argc + 2;
rec_argv = calloc(rec_argc + 1, sizeof(char *));
rec_argv[i++] = strdup("record");
--
1.7.1
next prev parent reply other threads:[~2012-04-12 12:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-12 12:20 [PATCH 0/3] perf, tool: kvm record & event processing fixies Jiri Olsa
2012-04-12 12:21 ` Jiri Olsa [this message]
2012-04-12 14:40 ` [PATCH 1/3] perf, tool: Force guest machine definition option David Ahern
2012-04-13 11:32 ` Jiri Olsa
2012-04-13 12:21 ` David Ahern
2012-04-13 12:41 ` Jiri Olsa
2012-04-13 14:15 ` David Ahern
2012-04-15 14:05 ` Jiri Olsa
2012-04-15 21:32 ` David Ahern
2012-04-12 12:21 ` [PATCH 2/3] perf, tool: Skip event correctly for unknown id/machine Jiri Olsa
2012-04-15 8:34 ` [tip:perf/urgent] perf session: " tip-bot for Jiri Olsa
2012-04-12 12:21 ` [PATCH 3/3] perf, tool: Fail on processing event with unknown size Jiri Olsa
2012-04-16 18:42 ` [PATCHv2 " Jiri Olsa
2012-05-11 6:37 ` [tip:perf/core] perf session: " tip-bot for Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334233262-5679-2-git-send-email-jolsa@redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome