From: Mike Galbraith <efault@gmx.de>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@redhat.com>
Subject: Re: RFC [patch] sched,cgroup_sched: convince RT_GROUP_SCHED throttle to work
Date: Sun, 15 Apr 2012 05:37:41 +0200 [thread overview]
Message-ID: <1334461061.5751.15.camel@marge.simpson.net> (raw)
In-Reply-To: <1334401847.2528.65.camel@twins>
On Sat, 2012-04-14 at 13:10 +0200, Peter Zijlstra wrote:
> On Tue, 2012-04-10 at 11:08 +0200, Mike Galbraith wrote:
>
> > --- a/kernel/sched/rt.c
> > +++ b/kernel/sched/rt.c
> > @@ -782,6 +782,19 @@ static int do_sched_rt_period_timer(stru
> > const struct cpumask *span;
> >
> > span = sched_rt_period_mask();
> > +#ifdef CONFIG_RT_GROUP_SCHED
> > + /*
> > + * FIXME: isolated CPUs should really leave the root task group,
>
> No no, that's the wrong fix, the right fix is to remove isolcpus :-)
Yeah, isolcpus needs to die, but...
> I guess the alternative 'fix' is to not account the rt_runtime on
> isolated cpus.. does something like the below actually work?
I haven't tried it, because the exact same thing happens when you
isolate via cpusets directly below root. One timer, two (or more)
rd->span, so _somebody_ is screwed.
-Mike
next prev parent reply other threads:[~2012-04-15 3:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-03 9:08 [patch] sched,rt: non-isolated cores lift isolcpus throttle for CONFIG_RT_GROUP_SCHED Mike Galbraith
2012-04-03 9:19 ` [patch] sched,rt: let the user see rt queues in /proc/sched_debug Mike Galbraith
2012-04-07 8:58 ` [patch] sched,cgroup_sched: fix up task_groups list buglet Mike Galbraith
2012-04-07 9:54 ` RFC [patch] sched,cgroup_sched: convince RT_GROUP_SCHED throttle to work Mike Galbraith
2012-04-10 9:08 ` Mike Galbraith
2012-04-14 11:10 ` Peter Zijlstra
2012-04-15 3:37 ` Mike Galbraith [this message]
2012-04-15 3:44 ` Mike Galbraith
2012-04-15 4:51 ` Mike Galbraith
2012-04-18 5:20 ` Yong Zhang
2012-04-18 6:27 ` Mike Galbraith
2012-04-18 7:48 ` Yong Zhang
2012-04-18 8:38 ` Mike Galbraith
2012-04-19 6:34 ` Yong Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334461061.5751.15.camel@marge.simpson.net \
--to=efault@gmx.de \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome