From: Ian Kent <raven@themaw.net>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: kernel-janitors@vger.kernel.org, autofs@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs/autofs4/dev-ioctl.c: add missing free_dev_ioctl
Date: Mon, 16 Apr 2012 09:19:59 +0800 [thread overview]
Message-ID: <1334539199.2250.1.camel@perseus.themaw.net> (raw)
In-Reply-To: <1334396928-17537-1-git-send-email-Julia.Lawall@lip6.fr>
On Sat, 2012-04-14 at 11:48 +0200, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Free param as done in the other error-handling code.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Oops!
Acked-by: Ian Kent <raven@themaw.net>
>
> ---
> fs/autofs4/dev-ioctl.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/autofs4/dev-ioctl.c b/fs/autofs4/dev-ioctl.c
> index 9dacb85..f99c2ce 100644
> --- a/fs/autofs4/dev-ioctl.c
> +++ b/fs/autofs4/dev-ioctl.c
> @@ -651,7 +651,8 @@ static int _autofs_dev_ioctl(unsigned int command, struct autofs_dev_ioctl __use
> fn = lookup_dev_ioctl(cmd);
> if (!fn) {
> AUTOFS_WARN("unknown command 0x%08x", command);
> - return -ENOTTY;
> + err = -ENOTTY;
> + goto out;
> }
>
> fp = NULL;
>
> --
> To unsubscribe from this list: send the line "unsubscribe autofs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2012-04-16 1:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-14 9:48 Julia Lawall
2012-04-16 1:19 ` Ian Kent [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334539199.2250.1.camel@perseus.themaw.net \
--to=raven@themaw.net \
--cc=Julia.Lawall@lip6.fr \
--cc=autofs@vger.kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®