From: Joe Perches <joe@perches.com>
To: Jesper Juhl <jj@chaosbits.net>
Cc: linux-kernel@vger.kernel.org, trivial@kernel.org,
devel@driverdev.osuosl.org, Xi Wang <xi.wang@gmail.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Forest Bond <forest@alittletooquiet.net>
Subject: Re: [PATCH][Trivial] staging: vt6656: Remove some redundant casts and parentheses + other style cleanups
Date: Tue, 17 Apr 2012 14:23:32 -0600 [thread overview]
Message-ID: <1334694212.1909.4.camel@joe2Laptop> (raw)
In-Reply-To: <alpine.LNX.2.00.1204162314480.21898@swampdragon.chaosbits.net>
On Mon, 2012-04-16 at 23:20 +0200, Jesper Juhl wrote:
> This is just a small/trivial cleanup patch. It makes the following
> changes to drivers/staging/vt6656/ioctl.c:
>
> 1. Remove some redundant casts.
drivers/staging/vt6656/wcmd.h:BOOL bScheduleCommand(void *hDeviceContext,
so you could remove the casts of the first argument too.
> diff --git a/drivers/staging/vt6656/ioctl.c b/drivers/staging/vt6656/ioctl.c
[]
> @@ -101,7 +101,7 @@ int private_ioctl(PSDevice pDevice, struct ifreq *rq)
> WLAN_CMD_BSSID_SCAN,
> abyScanSSID);
> else
> - bScheduleCommand((void *) pDevice, WLAN_CMD_BSSID_SCAN, NULL);
> + bScheduleCommand((void *)pDevice, WLAN_CMD_BSSID_SCAN, NULL);
bScheduleCommand(pDevice, WLAN_CMD_BSSID_SCAN, NULL);
[]
> @@ -190,10 +191,9 @@ int private_ioctl(PSDevice pDevice, struct ifreq *rq)
> netif_stop_queue(pDevice->dev);
> spin_lock_irq(&pDevice->lock);
> pMgmt->eCurrState = WMAC_STATE_IDLE;
> - bScheduleCommand((void *) pDevice,
> - WLAN_CMD_BSSID_SCAN,
> + bScheduleCommand((void *)pDevice, WLAN_CMD_BSSID_SCAN,
> pMgmt->abyDesireSSID);
bScheduleCommand(pDevice, WLAN_CMD_BSSID_SCAN,
pMgmt->abyDesireSSID);
etc
next prev parent reply other threads:[~2012-04-18 17:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-16 21:20 Jesper Juhl
2012-04-17 20:23 ` Joe Perches [this message]
2012-04-18 22:21 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334694212.1909.4.camel@joe2Laptop \
--to=joe@perches.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=jj@chaosbits.net \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
--cc=xi.wang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®