From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753767Ab2DRNWv (ORCPT ); Wed, 18 Apr 2012 09:22:51 -0400 Received: from mail-bk0-f74.google.com ([209.85.214.74]:38787 "EHLO mail-bk0-f74.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753511Ab2DRNWG (ORCPT ); Wed, 18 Apr 2012 09:22:06 -0400 From: Daniel Kurtz To: Dmitry Torokhov , Henrik Rydberg , Joonyoung Shim , Nick Dyer , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Benson Leung , Yufeng Shen , Daniel Kurtz Subject: [PATCH 13/14 v3] Input: atmel_mxt_ts - send all MT-B slots in one input report Date: Wed, 18 Apr 2012 21:21:58 +0800 Message-Id: <1334755319-21365-14-git-send-email-djkurtz@chromium.org> X-Mailer: git-send-email 1.7.7.3 In-Reply-To: <1334755319-21365-1-git-send-email-djkurtz@chromium.org> References: <1334755319-21365-1-git-send-email-djkurtz@chromium.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Each interrupt contains information for all contacts with changing properties. Process all of this information at once, and send it all in a a single input report (ie input events ending in EV_SYN/SYN_REPORT). This patch was tested using an MXT224E. Signed-off-by: Daniel Kurtz --- drivers/input/touchscreen/atmel_mxt_ts.c | 11 ++++++++--- 1 files changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c index 75e0108..6077b7c 100644 --- a/drivers/input/touchscreen/atmel_mxt_ts.c +++ b/drivers/input/touchscreen/atmel_mxt_ts.c @@ -540,9 +540,6 @@ static void mxt_input_touch(struct mxt_data *data, struct mxt_message *message) input_report_abs(input_dev, ABS_MT_TOUCH_MAJOR, area); /* TODO: Use vector to report ORIENTATION & TOUCH_MINOR */ } - - input_mt_report_pointer_emulation(input_dev, false); - input_sync(input_dev); } static irqreturn_t mxt_interrupt(int irq, void *dev_id) @@ -550,7 +547,9 @@ static irqreturn_t mxt_interrupt(int irq, void *dev_id) struct mxt_data *data = dev_id; struct mxt_message message; struct device *dev = &data->client->dev; + bool update_input; + update_input = false; do { if (mxt_read_message(data, &message)) { dev_err(dev, "Failed to read message\n"); @@ -560,11 +559,17 @@ static irqreturn_t mxt_interrupt(int irq, void *dev_id) if (message.reportid >= data->T9_reportid_min && message.reportid <= data->T9_reportid_max) { mxt_input_touch(data, &message); + update_input = true; } else { mxt_dump_message(dev, &message); } } while (message.reportid != 0xff); + if (update_input) { + input_mt_report_pointer_emulation(data->input_dev, false); + input_sync(data->input_dev); + } + end: return IRQ_HANDLED; } -- 1.7.7.3