From: ciminaghi@gnudd.com
To: vinod.koul@intel.com, linux-kernel@vger.kernel.org
Cc: dan.j.williams@intel.com, pgeninatti@soft-in.com,
acolosimo@soft-in.com, alarosa@openintellect.eu,
Davide Ciminaghi <ciminaghi@gnudd.com>
Subject: [PATCH] dmaengine/amba-pl08x : reset phychan_hold on terminate all
Date: Thu, 19 Apr 2012 12:20:24 +0200 [thread overview]
Message-ID: <1334830824-10908-1-git-send-email-ciminaghi@gnudd.com> (raw)
From: Davide Ciminaghi <ciminaghi@gnudd.com>
When a client calls pl08x_control with DMA_TERMINATE_ALL, it is correct
to terminate and release the phy channel currently in use (if one is in use),
but the phychan_hold counter must also be reset (otherwise it could get
trapped in an unbalanced state).
Signed-off-by: Davide Ciminaghi <ciminaghi@gnudd.com>
---
drivers/dma/amba-pl08x.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c
index c301a8e..3d704ab 100644
--- a/drivers/dma/amba-pl08x.c
+++ b/drivers/dma/amba-pl08x.c
@@ -1429,6 +1429,7 @@ static int pl08x_control(struct dma_chan *chan, enum dma_ctrl_cmd cmd,
* signal
*/
release_phy_channel(plchan);
+ plchan->phychan_hold = 0;
}
/* Dequeue jobs and free LLIs */
if (plchan->at) {
--
1.7.9.1
next reply other threads:[~2012-04-19 10:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-19 10:20 ciminaghi [this message]
2012-04-23 12:42 ` Vinod Koul
2012-04-24 4:06 ` Viresh Kumar
2012-04-24 13:08 ` Linus Walleij
2012-04-25 9:41 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334830824-10908-1-git-send-email-ciminaghi@gnudd.com \
--to=ciminaghi@gnudd.com \
--cc=acolosimo@soft-in.com \
--cc=alarosa@openintellect.eu \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pgeninatti@soft-in.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®