From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754297Ab2DTNvZ (ORCPT ); Fri, 20 Apr 2012 09:51:25 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.122]:11263 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751543Ab2DTNvY (ORCPT ); Fri, 20 Apr 2012 09:51:24 -0400 X-Authority-Analysis: v=2.0 cv=XbcLPfF5 c=1 sm=0 a=ZycB6UtQUfgMyuk2+PxD7w==:17 a=XQbtiDEiEegA:10 a=O9SDWPecf0MA:10 a=5SG0PmZfjMsA:10 a=Q9fys5e9bTEA:10 a=zrfWMziO8bEgIQt9m90A:9 a=PUjeQqilurYA:10 a=ZycB6UtQUfgMyuk2+PxD7w==:117 X-Cloudmark-Score: 0 X-Originating-IP: 74.67.80.29 Message-ID: <1334929881.28106.77.camel@gandalf.stny.rr.com> Subject: Re: [patch] tracing: Remove an unneeded check From: Steven Rostedt To: Dan Carpenter Cc: Frederic Weisbecker , Eduard - Gabriel Munteanu , Ingo Molnar , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Date: Fri, 20 Apr 2012 09:51:21 -0400 In-Reply-To: <20120420063145.GA22649@elgon.mountain> References: <20120420063145.GA22649@elgon.mountain> Content-Type: text/plain; charset="ISO-8859-15" X-Mailer: Evolution 3.2.2-1 Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2012-04-20 at 09:31 +0300, Dan Carpenter wrote: > memcpy() returns a pointer to "bug". Hopefully, it's not NULL here or > we would already have Oopsed. You're right that the ret is useless, and the real bug was already fixed (the possibility that buf could be an invalid pointer). Not only is this needed, but also get rid of the ret < 0 check in tracing_splice_read_pipe(). -- Steve