From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932138Ab2DTWLy (ORCPT ); Fri, 20 Apr 2012 18:11:54 -0400 Received: from h1446028.stratoserver.net ([85.214.92.142]:57074 "EHLO mail.ahsoftware.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753570Ab2DTWLw (ORCPT ); Fri, 20 Apr 2012 18:11:52 -0400 From: Alexander Holler To: linux-kernel@vger.kernel.org Cc: Steve Glendinning , linux-fbdev@vger.kernel.org, Alexander Holler Subject: [PATCH] video/smscufx: fix line counting in fb_write Date: Sat, 21 Apr 2012 00:11:07 +0200 Message-Id: <1334959867-3719-1-git-send-email-holler@ahsoftware.de> X-Mailer: git-send-email 1.7.6.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Line 0 and 1 were both written to line 0 (on the display) and all subsequent lines had an offset of -1. The result was that the last line on the display was never overwritten by writes to /dev/fbN. The origin of this bug seems to have been udlfb. Signed-off-by: Alexander Holler --- drivers/video/smscufx.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/video/smscufx.c b/drivers/video/smscufx.c index ccbfef5..1e1e2d2 100644 --- a/drivers/video/smscufx.c +++ b/drivers/video/smscufx.c @@ -904,7 +904,7 @@ static ssize_t ufx_ops_write(struct fb_info *info, const char __user *buf, result = fb_sys_write(info, buf, count, ppos); if (result > 0) { - int start = max((int)(offset / info->fix.line_length) - 1, 0); + int start = max((int)(offset / info->fix.line_length), 0); int lines = min((u32)((result / info->fix.line_length) + 1), (u32)info->var.yres); -- 1.7.6.5