From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C2F23EFFC1; Tue, 9 Jun 2026 10:28:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781000917; cv=none; b=i3wMAcVYLsnKDYRTv3DRpaV/DQ09MwMX2ZltI4Q02UR/g6FXqRIMpeBm+1/Ql5lv1hL5/07CL9P8ke0iEYV1s700jE79SKePa9F9wDdVCtVd+ytY1ugnuszvKvKwXRzWNY70NWCsawQdf5F6UusGxMPUbF6nTJXt0vEJUU8eL0c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781000917; c=relaxed/simple; bh=bvANr5vckOWD1dE5GDRFS+Zh0rUsrhH3VSGfBc8NN5o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ndLg/BUj2599aCFxNaD8rymlZsmKkxGy10ZCDnFstwySL8DJtF04tiFMxd2RsxbGFvgrx8jHXjWd4NLEhXRGVPArTIBqmDrMNLN9uXvHCC5vNrI022X8ZLFK8mLCma3oczZBoVeyXIyO+9xfAoyFS4cmfnTSgeTOtl+W2hf+GtE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=de+Gt/cJ; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="de+Gt/cJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9DD741F00893; Tue, 9 Jun 2026 10:28:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781000915; bh=RagWXXM2ZvzMuy//ic4znnElaVbSdrz9ijumhEajm38=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=de+Gt/cJMJuRjeouDp+emmcAei3h1vWnQwsk7W1P3Z99grZ4Jhcx59gO1GNqwdXxB BJgs1i1PQxcsWr1Lr9d+JA2WqRqJDb24Kl4hjGr/58BuR+XNZNgiSx7MmLQhUg+pYP DkI85uv6gRbE1Dd9jB3keF+oAe9a6CaZG109wj4yZw8mqiZP3W+/y8HIBJ2UXTVoCC 7Wcgoxbsf0NOKAMax9G0jGaN8N1QhKFPUGLPRwAV888m0ojS4BO3cn4KblZgJEIBfX QmkH0pxvtH6uAdOld1FYNlAk6rorNZ8v51WlmVOiivov0XcQqgzDc+Yd4qzTEE9fJJ bT+7JZgCXhx8g== Message-ID: <13349811-31e3-4658-911f-6f93d74efaaa@kernel.org> Date: Tue, 9 Jun 2026 12:28:28 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: glymur: Drop fake PCIe phy 3B To: Konrad Dybcio , Krzysztof Kozlowski , Dmitry Baryshkov Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260420133616.88740-2-krzysztof.kozlowski@oss.qualcomm.com> <5c1f7955-883f-4fa8-a0e5-513a987bd3a9@oss.qualcomm.com> <0710caaf-ec73-4c4c-b6cb-7fe716724f4b@oss.qualcomm.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGPBBMBCgA5AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJp2mE8AAoJEBuTQ307QWKbeaIP /ihHTkTW4KsN/DQ945JJbyu5tI0J80Wue7QyyLPglyKfhgb5cLLNPpOC8cCIJsc7+W3i2P38 s2c1cOH6CYGE7E9ur3Vfme8NW2S2I/Z8VC7bZnzyS23wT17LrsdS/qCpx4o8U+pt/xdXDKph EGRYrIEmMpUWvyYzyYKGIe25FtaayIIKpq8eZYyFcp2f/sG5IkOW5uZzHPMPdcm87jU7fyuQ rAU2vx9r+ulUfQ/q9Z2roC/ode3l7t2pN7BCBCsUDp6JCrUyZrtT1e7EbA0ZRP3aOBNk2P2E DQOgJGjGdO5Yx2Y9LFtltu6JbsBJHi1syGRX3AtQYOMc4Y1WGoeZJmMlvKj2ZqqXNkcWi2DS IQEWB0uW6CqFsBBIMGDa+6OzdaVO/uAVXWDWml02Men3CILdI1MbVjoh8ECqYUY7OQ+JJvNN vnliuq5WM3Ghd3jg/LZZrxXjdIginRHFQCjIJYLKpLZWm1/iDFedcfzqRNYmTtqscdCNHW41 oT3Z7BmO9xwdjuwBS6nmS6JJwkbf5Ot2QR4pB/DRU7ZwjT1qHe+9r9gF32wXVQatHNGK/VVu sfwOnkdxCWkp/qb2gdQRmZh+SedStWshigH6sNfuHBloF/q+hjMRc8b2m326OZdrbSHwY1Sz vti8Hn7n8NjdHO9LKB7BIdjkA9DA5WsqOuVCzsFNBFVDXDQBEADNkrQYSREUL4D3Gws46JEo Z9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLueMNsWLJBv BaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6eiOMheesVS 5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wAGldWsRxb f3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA6z6lBZn0 WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9YegxWKvX XHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt91pFzBSO IpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gUBLHFTg2h YnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/JoFzZ4B0 p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu4vXVFBYI GmpyNPYzRm0QPwARAQABwsF2BBgBCgAgAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmna YUkACgkQG5NDfTtBYptX+BAApg32CkxwNucNEi8WfWA8oKkW0y8YDuY6ORMo9FWNGiT/OTy0 vyJrLocrpn86zwfjVp+eCrssPYh8eqJfnWqmYv6ACQtHPYzPZQ3mSo8H97Z01oUxITzCxpXm ZkLgPIqtDPcC2E3dPM/fVxcyowM8XsaMA9wcsaUYrta8toOq2b9tKcjleKMfMrm0gQ9u7wUc QbLkwj6TCLOwucb07GXzLTNF9PZmaDUpKAZjMjmrW+le+SFvQbhamx0rxLWPR0NWntXpbCn+ +ACch03p/JyTBVktxFsFyCt7pTPE1kEaeuXBTe/a2D9iQvRxRW19LvuO2e59/u1wYUiH/orz wbIC2S4dBsPAPihL3ztOU1yE86GPyQtSE0kU+/7snnLt4QGi6PChf3t5gnNjAzjUUovO8rgI c+5yN5heq5loYHgK6OQ9OlHzsPHO9e9MOQcKlFycs1pyijFGzDwdNUm/SchK8iWT2QApTx4A K9bCVaboTA2T77QYkRcRJYSsO1alGX0ome/hMLD1daXlkrNUp1HWa3K4iytLRXjCSIorWiGs n+q3krnpXu3TFkA8qtOFZMdnIiFuiq1yLT8hptsV5xh1TA2nsVvSYiaCr3q4s4BKjS/KrLDb qoxzw8ISjdUp4pA85vb6YLCmb39NgidD+7PmAr65lBNveIFynTgsja1rRQ4= In-Reply-To: <0710caaf-ec73-4c4c-b6cb-7fe716724f4b@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 24/04/2026 13:09, Konrad Dybcio wrote: > On 4/23/26 9:16 AM, Krzysztof Kozlowski wrote: >> On 22/04/2026 22:08, Dmitry Baryshkov wrote: >>> On Tue, Apr 21, 2026 at 08:41:14AM +0200, Krzysztof Kozlowski wrote: >>>> On 20/04/2026 20:02, Dmitry Baryshkov wrote: >>>>> On Mon, Apr 20, 2026 at 03:36:17PM +0200, Krzysztof Kozlowski wrote: >>>>>> According to user manual / programming guide there is no separate PCIe >>>>>> phy 3A and 3B, but one 8-lane QMP PCIe Gen5 PHY which consists of two >>>>>> 4-lane blocks. This is also visible in memory map, where the 0xf00000 >>>>>> is marked as the main block with additional sub blocks for each 4-lane >>>>>> phys. >>>>>> >>>>>> Describing the sub phys without the rest is not correct from hardware >>>>>> description, even if it works. >>>>> >>>>> Is this the case for the other bifurcated PHYs? >>>>> >>>> >>>> There's more? Oh damn... >>> >>> In the previous generations. I think Hamoa had one. > > Any PHY with a name ending in -A or -B. That means: > > $ rg 'PCIE_.[AB]_' drivers/clk/qcom/ -l > drivers/clk/qcom/gcc-x1e80100.c > drivers/clk/qcom/gcc-glymur.c > drivers/clk/qcom/gcc-sc8280xp.c > > > And, quite predictably, some PHYs may not only bifurcate, but also > tri- or quadfurcate (on Nord). > >> Ah, I did not check the others and there is little we can do there - >> it's released DTS. This cannot be easily changed while keeping DTS >> compatible with users, because probably two PHY nodes will be replaced >> by one with different compatible. > > I think no one utilized the non-reference configuration of those PHYs > in practice. Should a device like that come around though, we'll think > about what to do then.. > What is the resolution of this discussion? I have impression that no one objected to my patch, so maybe I should resend it? Best regards, Krzysztof