From: Suresh Siddha <suresh.b.siddha@intel.com>
To: Greg Pearson <greg.pearson@hp.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] x86: Use x2apic physical mode based on FADT setting
Date: Tue, 24 Apr 2012 18:45:45 -0700 [thread overview]
Message-ID: <1335318345.28674.268.camel@sbsiddha-desk.sc.intel.com> (raw)
In-Reply-To: <1335313436-32020-1-git-send-email-greg.pearson@hp.com>
On Tue, 2012-04-24 at 18:23 -0600, Greg Pearson wrote:
> Provide systems that do not support x2apic cluster mode
> a mechanism to select x2apic physical mode using the
> FADT FORCE_APIC_PHYSICAL_DESTINATION_MODE bit.
>
> Changes from v1: (based on Suresh's comments)
> - removed #ifdef CONFIG_ACPI
> - removed #include <linux/acpi.h>
>
> Signed-off-by: Greg Pearson <greg.pearson@hp.com>
> ---
> arch/x86/kernel/apic/x2apic_phys.c | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/arch/x86/kernel/apic/x2apic_phys.c b/arch/x86/kernel/apic/x2apic_phys.c
> index 8a778db..991e315 100644
> --- a/arch/x86/kernel/apic/x2apic_phys.c
> +++ b/arch/x86/kernel/apic/x2apic_phys.c
> @@ -24,6 +24,12 @@ static int x2apic_acpi_madt_oem_check(char *oem_id, char *oem_table_id)
> {
> if (x2apic_phys)
> return x2apic_enabled();
> + else if ((acpi_gbl_FADT.header.revision >= FADT2_REVISION_ID) &&
> + (acpi_gbl_FADT.flags & ACPI_FADT_APIC_PHYSICAL) &&
> + x2apic_enabled()) {
> + printk(KERN_DEBUG "System requires x2apic physical mode\n");
> + return 1;
> + }
> else
> return 0;
> }
Acked-by: Suresh Siddha <suresh.b.siddha@intel.com>
next prev parent reply other threads:[~2012-04-25 1:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-25 0:23 Greg Pearson
2012-04-25 1:45 ` Suresh Siddha [this message]
2012-04-25 13:57 ` [tip:x86/urgent] x86/apic: " tip-bot for Greg Pearson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1335318345.28674.268.camel@sbsiddha-desk.sc.intel.com \
--to=suresh.b.siddha@intel.com \
--cc=greg.pearson@hp.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®