From: xiong <xiong@qca.qualcomm.com>
To: <davem@davemloft.net>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Cc: <qca-linux-team@qualcomm.com>, <nic-devel@qualcomm.com>,
xiong <xiong@qca.qualcomm.com>
Subject: [PATCH 07/10] atl1c: remove PHY reset/init for link down event
Date: Thu, 26 Apr 2012 14:27:15 +0800 [thread overview]
Message-ID: <1335421638-16304-8-git-send-email-xiong@qca.qualcomm.com> (raw)
In-Reply-To: <1335421638-16304-1-git-send-email-xiong@qca.qualcomm.com>
it's unnecessary to reset/init phy when link down.
Only L1/L2 chip (supported by atlx) need such action.
Signed-off-by: xiong <xiong@qca.qualcomm.com>
Tested-by: Liu David <dwliu@qca.qualcomm.com>
---
drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
index 995da22..cb3b3c4 100644
--- a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
+++ b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
@@ -270,8 +270,6 @@ static void atl1c_check_link_status(struct atl1c_adapter *adapter)
atl1c_set_aspm(hw, SPEED_0);
netif_carrier_off(netdev);
netif_stop_queue(netdev);
- atl1c_phy_reset(hw);
- atl1c_phy_init(&adapter->hw);
} else {
/* Link Up */
hw->hibernate = false;
--
1.7.7
next prev parent reply other threads:[~2012-04-26 6:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-26 6:27 [PATCH 00/10] atl1c: update hardware settings - v3 xiong
2012-04-26 6:27 ` [PATCH 01/10] atl1c: remove REG_PHY_STATUS xiong
2012-04-26 6:27 ` [PATCH 02/10] atl1c: refine phy-register read/write function xiong
2012-04-26 6:27 ` [PATCH 03/10] atl1c: remove PHY contrl in atl1c_reset_pcie xiong
2012-04-26 6:27 ` [PATCH 04/10] atl1c: refine SERDES-clock related code xiong
2012-04-26 6:27 ` [PATCH 05/10] atl1c: remove PHY polling from atl1c_open xiong
2012-04-26 6:27 ` [PATCH 06/10] atl1c: update PHY reset related routine xiong
2012-04-26 6:27 ` xiong [this message]
2012-04-26 9:05 ` [PATCH 00/10] atl1c: update hardware settings - v3 David Miller
2012-04-26 9:13 ` Huang, Xiong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1335421638-16304-8-git-send-email-xiong@qca.qualcomm.com \
--to=xiong@qca.qualcomm.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic-devel@qualcomm.com \
--cc=qca-linux-team@qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®