From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757508Ab2DZPGn (ORCPT ); Thu, 26 Apr 2012 11:06:43 -0400 Received: from merlin.infradead.org ([205.233.59.134]:48940 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757033Ab2DZPGc (ORCPT ); Thu, 26 Apr 2012 11:06:32 -0400 From: Arnaldo Carvalho de Melo To: Ingo Molnar Cc: linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo , David Ahern , Frederic Weisbecker , Hagen Paul Pfeifer , Mike Galbraith , Namhyung Kim , Paul Mackerras , Peter Zijlstra , Stephane Eranian , arnaldo.melo@gmail.com, Arnaldo Carvalho de Melo Subject: [GIT PULL 0/4] perf/annotate loop detection V2, fixes Date: Thu, 26 Apr 2012 12:06:13 -0300 Message-Id: <1335452777-27326-1-git-send-email-acme@infradead.org> X-Mailer: git-send-email 1.7.9.2.358.g22243 X-SRS-Rewrite: SMTP reverse-path rewritten from by canuck.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ingo, Please consider pulling into tip/perf/core. Just flushing out the annotate queue before it gets too big. I'll work on the suggestions made on G+ and on lkml. - Arnaldo The following changes since commit a3f895be1f1ed17f66e6e71adeef0cc7f937512c: perf annotate browser: Initial loop detection (2012-04-24 14:24:28 -0300) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-annotate-for-mingo for you to fetch changes up to 38b31bd0cefbb0e69a182d9a94b09a7e648549dc: perf annotate browser: Don't draw jump connectors for out of function jumps (2012-04-25 14:18:42 -0300) ---------------------------------------------------------------- Fixes on top of the previous perf/annotate pull request . Sometimes a jump points to an offset with no instructions, make the mark jump targets function handle that, for now just ignoring such jump targets, more investigation is needed to figure out how to cope with that. . Handle jump targets that are outside the function, for now just don't try to draw the connector arrow, right thing seems to be to mark this jump with a -> (right arrow) and handle it like a callq. Signed-off-by: Arnaldo Carvalho de Melo ---------------------------------------------------------------- Arnaldo Carvalho de Melo (4): perf annotate browser: Handle NULL jump targets perf annotate: Disambiguage offsets and addresses in operands perf annotate: Mark jump instructions with no offset perf annotate browser: Don't draw jump connectors for out of function jumps tools/perf/ui/browsers/annotate.c | 27 ++++++++++++++++++--------- tools/perf/util/annotate.c | 27 +++++++++++++++------------ tools/perf/util/annotate.h | 13 +++++++++++-- 3 files changed, 44 insertions(+), 23 deletions(-)