From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758636Ab2DZSLp (ORCPT ); Thu, 26 Apr 2012 14:11:45 -0400 Received: from mx2.netapp.com ([216.240.18.37]:7976 "EHLO mx2.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754706Ab2DZSLo (ORCPT ); Thu, 26 Apr 2012 14:11:44 -0400 X-IronPort-AV: E=Sophos;i="4.75,487,1330934400"; d="scan'208";a="643681473" From: "Myklebust, Trond" To: Stanislav Kinsbursky CC: "bfields@fieldses.org" , "linux-nfs@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devel@openvz.org" Subject: Re: [PATCH 2/3] SUNRPC: traverse clients tree on PipeFS event Thread-Topic: [PATCH 2/3] SUNRPC: traverse clients tree on PipeFS event Thread-Index: AQHNHwCml0nktMD7qUOuv65VsxBLHpat52cA Date: Thu, 26 Apr 2012 18:11:42 +0000 Message-ID: <1335463902.9701.35.camel@lade.trondhjem.org> References: <20120420141419.10848.84280.stgit@localhost6.localdomain6> <20120420141925.10848.90395.stgit@localhost6.localdomain6> In-Reply-To: <20120420141925.10848.90395.stgit@localhost6.localdomain6> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.104.60.115] Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id q3QIBwM5015796 On Fri, 2012-04-20 at 18:19 +0400, Stanislav Kinsbursky wrote: > +static int __rpc_pipefs_event(struct rpc_clnt *clnt, unsigned long event, > + struct super_block *sb) > +{ > + int error; > + > + if (!rpc_clnt_skip_event(clnt, event)) { > + error = __rpc_clnt_handle_event(clnt, event, sb); > + if (error) > + return error; > + } > + if (clnt != clnt->cl_parent) > + return __rpc_pipefs_event(clnt->cl_parent, event, sb); > + return 0; > +} Hi Stanislav, Recursion in the kernel is generally frowned upon due to the stack size limits. Could you please rewrite the above into a simple loop. Something along the lines of: for(;;) { ... if (clnt == clnt->cl_parent) break; clnt = clnt->cl_parent; } -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust@netapp.com www.netapp.com {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I