From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Hugo Villeneuve <hugo@hugovil.com>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
leoyang.li@nxp.com, robh@kernel.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Hugo Villeneuve <hvilleneuve@dimonoff.com>
Subject: Re: [PATCH v3 2/3] dt-bindings: arm: fsl: add RVE gateway board
Date: Thu, 2 Nov 2023 22:14:41 +0100 [thread overview]
Message-ID: <13357eac-7616-4e3f-965b-52ecae01ab92@linaro.org> (raw)
In-Reply-To: <20231102193121.1676000-3-hugo@hugovil.com>
On 02/11/2023 20:31, Hugo Villeneuve wrote:
> From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
>
> Add DT compatible string for RVE gateway board based on a Variscite
> VAR-SOM-NANO with a NXP MX8MN nano CPU.
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> ---
> Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 32b195852a75..4cef18e46312 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -1018,6 +1018,7 @@ properties:
> - fsl,imx8mn-ddr4-evk # i.MX8MN DDR4 EVK Board
> - fsl,imx8mn-evk # i.MX8MN LPDDR4 EVK Board
> - gw,imx8mn-gw7902 # i.MX8MM Gateworks Board
> + - rve,rve-gateway # i.MX8MN RVE Gateway Board
Eh, now it does not match your DTS.
It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-11-02 21:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-02 19:31 [PATCH v3 0/3] board: imx8mn-rve-gateway: add support for " Hugo Villeneuve
2023-11-02 19:31 ` [PATCH v3 1/3] dt-bindings: vendor-prefixes: add rve Hugo Villeneuve
2023-11-02 19:31 ` [PATCH v3 2/3] dt-bindings: arm: fsl: add RVE gateway board Hugo Villeneuve
2023-11-02 21:14 ` Krzysztof Kozlowski [this message]
2023-11-02 22:21 ` Hugo Villeneuve
2023-11-02 19:31 ` [PATCH v3 3/3] arm64: dts: freescale: introduce rve-gateway board Hugo Villeneuve
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13357eac-7616-4e3f-965b-52ecae01ab92@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=hugo@hugovil.com \
--cc=hvilleneuve@dimonoff.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®