From: Jan Kara <jack@suse.cz>
To: Jens Axboe <axboe@kernel.dk>
Cc: LKML <linux-kernel@vger.kernel.org>, Jan Kara <jack@suse.cz>,
Paolo Bonzini <pbonzini@redhat.com>, Jens Axboe <axboe@kernel.dk>,
James Bottomley <JBottomley@parallels.com>,
linux-scsi@vger.kernel.org
Subject: [PATCH] scsi: Silence unnecessary warnings about ioctl to partition
Date: Wed, 2 May 2012 12:10:52 +0200 [thread overview]
Message-ID: <1335953452-10460-1-git-send-email-jack@suse.cz> (raw)
Sometimes, warnings about ioctls to partition happen often enough that they
form majority of the warnings in the kernel log and users complain. In some
cases warnings are about ioctls such as SG_IO so it's not good to get rid of
the warnings completely as they can ease debugging of userspace problems
when ioctl is refused.
Since I have seen warnings from lots of commands, including some proprietary
userspace applications, I don't think disallowing the ioctls for processes
with CAP_SYS_RAWIO will happen in the near future if ever. So lets just
stop warning for processes with CAP_SYS_RAWIO for which ioctl is allowed.
CC: Paolo Bonzini <pbonzini@redhat.com>
CC: Jens Axboe <axboe@kernel.dk>
CC: James Bottomley <JBottomley@parallels.com>
CC: linux-scsi@vger.kernel.org
Signed-off-by: Jan Kara <jack@suse.cz>
---
block/scsi_ioctl.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/block/scsi_ioctl.c b/block/scsi_ioctl.c
index 260fa80..9a87daa 100644
--- a/block/scsi_ioctl.c
+++ b/block/scsi_ioctl.c
@@ -721,11 +721,14 @@ int scsi_verify_blk_ioctl(struct block_device *bd, unsigned int cmd)
break;
}
+ if (capable(CAP_SYS_RAWIO))
+ return 0;
+
/* In particular, rule out all resets and host-specific ioctls. */
printk_ratelimited(KERN_WARNING
"%s: sending ioctl %x to a partition!\n", current->comm, cmd);
- return capable(CAP_SYS_RAWIO) ? 0 : -ENOIOCTLCMD;
+ return -ENOIOCTLCMD;
}
EXPORT_SYMBOL(scsi_verify_blk_ioctl);
--
1.7.1
next reply other threads:[~2012-05-02 10:11 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-02 10:10 Jan Kara [this message]
2012-05-02 10:15 ` Paolo Bonzini
2012-05-02 10:37 ` Jens Axboe
2012-05-02 10:54 ` Alan Cox
2012-05-02 11:02 ` Paolo Bonzini
2012-05-02 11:12 ` Alan Cox
2012-05-02 11:24 ` Paolo Bonzini
2012-05-02 12:05 ` Alan Cox
2012-05-02 12:23 ` Paolo Bonzini
2012-05-02 19:38 ` Mark Lord
2012-05-03 7:47 ` Paolo Bonzini
2012-05-03 12:40 ` Mark Lord
2012-05-03 12:47 ` Paolo Bonzini
2012-05-03 17:36 ` Mark Lord
2012-05-04 6:39 ` Paolo Bonzini
2012-05-04 13:06 ` Mark Lord
2012-05-04 13:08 ` Paolo Bonzini
2012-05-04 13:11 ` Mark Lord
2012-05-04 13:24 ` Mark Lord
2012-05-02 13:51 ` Jan Kara
2012-05-02 13:59 ` Paolo Bonzini
2012-05-02 15:10 ` Alan Cox
2012-05-02 15:49 ` Paolo Bonzini
2012-05-02 20:49 ` Paolo Bonzini
2012-05-02 19:49 ` Jan Kara
2012-05-02 21:16 ` Paolo Bonzini
2012-06-15 8:14 ` Paolo Bonzini
2012-06-15 8:46 ` Jan Kara
2012-06-15 10:50 Jan Kara
2012-06-15 10:51 ` Jens Axboe
2012-06-15 13:58 ` Nick Bowler
2012-06-15 14:22 ` Paolo Bonzini
2012-06-15 14:23 ` Jan Kara
2012-06-15 14:31 ` Nick Bowler
2012-06-15 11:00 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1335953452-10460-1-git-send-email-jack@suse.cz \
--to=jack@suse.cz \
--cc=JBottomley@parallels.com \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®