From: Rhyland Klein <rklein@nvidia.com>
To: Nikolaus Voss <n.voss@weinmann.de>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"cbouatmailru@gmail.com" <cbouatmailru@gmail.com>
Subject: Re: [PATCH] drivers/power/sbs-battery.c: capacity attr = remaining relative capacity
Date: Fri, 4 May 2012 08:24:43 -0700 [thread overview]
Message-ID: <1336145083.2210.1.camel@rhyland-vb> (raw)
In-Reply-To: <201204250721.q3P7LmQN009128@gatekeeper.vosshq.de>
On Tue, 2012-04-24 at 23:59 -0700, Nikolaus Voss wrote:
> Currently, the capacity exported by this driver refers to reg 0x0e,
> which is the absolute state of charge which according to SBS
> refers to the design capacity/ energy of the battery. It can be
> > 100 % and drops below 100 % for a fully charged battery with
> the battery aging.
>
> This is not what the user exspects of a remaining capacity
> indication between 0 and 100 % with 100 % referring to
> a fully charged battery. This is provided by SBS reg 0x0d,
> which is the relative state of charge referring to the
> full charge capacity.
>
> Signed-off-by: Nikolaus Voss <n.voss@weinmann.de>
> ---
> drivers/power/sbs-battery.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Ack-ed Rhyland Klein <rklein@nvidia.com>
next prev parent reply other threads:[~2012-05-04 15:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-25 6:59 Nikolaus Voss
2012-05-04 15:24 ` Rhyland Klein [this message]
2012-05-06 3:06 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336145083.2210.1.camel@rhyland-vb \
--to=rklein@nvidia.com \
--cc=cbouatmailru@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=n.voss@weinmann.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®