From: Mike Galbraith <efault@gmx.de>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Oleg Nesterov <oleg@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
Pavel Emelyanov <xemul@parallels.com>,
Cyrill Gorcunov <gorcunov@openvz.org>,
Louis Rilling <louis.rilling@kerlabs.com>
Subject: Re: [PATCH] Re: [RFC PATCH] namespaces: fix leak on fork() failure
Date: Sat, 05 May 2012 08:08:13 +0200 [thread overview]
Message-ID: <1336198093.7346.11.camel@marge.simpson.net> (raw)
In-Reply-To: <1336197362.7346.9.camel@marge.simpson.net>
On Sat, 2012-05-05 at 07:56 +0200, Mike Galbraith wrote:
> On Fri, 2012-05-04 at 13:29 -0700, Eric W. Biederman wrote:
>
> > Shrug. I have skimmed through all of that code and I don't see anything
> > obvious. I guess it would take a few more data points to figure out
> > where we are sleeping for a jiffy or two while we are reaping children.
egrep 'synchronize|rcu_barrier' /trace
vsftpd-7981 [003] .... 577.164997: synchronize_sched <-switch_task_namespaces
vsftpd-7981 [003] .... 577.164998: _cond_resched <-synchronize_sched
vsftpd-7981 [003] .... 577.164998: wait_rcu_gp <-synchronize_sched
vsftpd-7982 [003] .... 577.166583: synchronize_sched <-switch_task_namespaces
vsftpd-7982 [003] .... 577.166583: _cond_resched <-synchronize_sched
vsftpd-7982 [003] .... 577.166584: wait_rcu_gp <-synchronize_sched
vsftpd-7983 [003] .... 577.167128: synchronize_sched <-switch_task_namespaces
vsftpd-7983 [003] .... 577.167129: _cond_resched <-synchronize_sched
vsftpd-7983 [003] .... 577.167129: wait_rcu_gp <-synchronize_sched
vsftpd-7980 [003] .... 577.167678: synchronize_sched <-switch_task_namespaces
vsftpd-7980 [003] .... 577.167679: _cond_resched <-synchronize_sched
vsftpd-7980 [003] .... 577.167679: wait_rcu_gp <-synchronize_sched
vsftpd-7984 [003] .... 577.168232: synchronize_sched <-switch_task_namespaces
vsftpd-7984 [003] .... 577.168232: _cond_resched <-synchronize_sched
vsftpd-7984 [003] .... 577.168233: wait_rcu_gp <-synchronize_sched
vsftpd-7979 [003] .... 577.168800: synchronize_sched <-switch_task_namespaces
vsftpd-7979 [003] .... 577.168800: _cond_resched <-synchronize_sched
vsftpd-7979 [003] .... 577.168801: wait_rcu_gp <-synchronize_sched
vsftpd-7985 [003] .... 577.169373: synchronize_sched <-switch_task_namespaces
vsftpd-7985 [003] .... 577.169373: _cond_resched <-synchronize_sched
vsftpd-7985 [003] .... 577.169373: wait_rcu_gp <-synchronize_sched
vsftpd-7986 [003] .... 577.169946: synchronize_sched <-switch_task_namespaces
vsftpd-7986 [003] .... 577.169947: _cond_resched <-synchronize_sched
vsftpd-7986 [003] .... 577.169947: wait_rcu_gp <-synchronize_sched
vsftpd-7987 [003] .... 577.170519: synchronize_sched <-switch_task_namespaces
vsftpd-7987 [003] .... 577.170519: _cond_resched <-synchronize_sched
vsftpd-7987 [003] .... 577.170519: wait_rcu_gp <-synchronize_sched
vsftpd-7978 [003] .... 577.171091: synchronize_sched <-switch_task_namespaces
vsftpd-7978 [003] .... 577.171091: _cond_resched <-synchronize_sched
vsftpd-7978 [003] .... 577.171091: wait_rcu_gp <-synchronize_sched
vsftpd-7977 [003] .... 577.171519: rcu_barrier <-deactivate_locked_super
vsftpd-7977 [003] .... 577.171519: rcu_barrier_sched <-rcu_barrier
vsftpd-7977 [003] .... 577.171519: _rcu_barrier.isra.31 <-rcu_barrier_sched
vsftpd-7977 [003] .... 577.171519: mutex_lock <-_rcu_barrier.isra.31
vsftpd-7977 [003] .... 577.171520: __init_waitqueue_head <-_rcu_barrier.isra.31
vsftpd-7977 [003] .... 577.171520: on_each_cpu <-_rcu_barrier.isra.31
vsftpd-7977 [003] d... 577.171532: rcu_barrier_func <-on_each_cpu
vsftpd-7977 [003] d... 577.171532: call_rcu_sched <-rcu_barrier_func
vsftpd-7977 [003] .... 577.171533: wait_for_completion <-_rcu_barrier.isra.31
ksoftirqd/3-16 [003] ..s. 577.171691: rcu_barrier_callback <-__rcu_process_callbacks
vsftpd-7977 [003] .... 577.176443: mutex_unlock <-_rcu_barrier.isra.31
vsftpd-7977 [003] .... 577.176552: rcu_barrier <-deactivate_locked_super
vsftpd-7977 [003] .... 577.176552: rcu_barrier_sched <-rcu_barrier
vsftpd-7977 [003] .... 577.176553: _rcu_barrier.isra.31 <-rcu_barrier_sched
vsftpd-7977 [003] .... 577.176553: mutex_lock <-_rcu_barrier.isra.31
vsftpd-7977 [003] .... 577.176553: __init_waitqueue_head <-_rcu_barrier.isra.31
vsftpd-7977 [003] .... 577.176554: on_each_cpu <-_rcu_barrier.isra.31
vsftpd-7977 [003] d... 577.176561: rcu_barrier_func <-on_each_cpu
vsftpd-7977 [003] d... 577.176561: call_rcu_sched <-rcu_barrier_func
vsftpd-7977 [003] .... 577.176562: wait_for_completion <-_rcu_barrier.isra.31
ksoftirqd/3-16 [003] ..s. 577.176730: rcu_barrier_callback <-__rcu_process_callbacks
vsftpd-7977 [003] .... 577.180448: mutex_unlock <-_rcu_barrier.isra.31
vsftpd-7977 [003] .... 577.180553: rcu_barrier <-deactivate_locked_super
vsftpd-7977 [003] .... 577.180553: rcu_barrier_sched <-rcu_barrier
vsftpd-7977 [003] .... 577.180554: _rcu_barrier.isra.31 <-rcu_barrier_sched
vsftpd-7977 [003] .... 577.180554: mutex_lock <-_rcu_barrier.isra.31
vsftpd-7977 [003] .... 577.180555: __init_waitqueue_head <-_rcu_barrier.isra.31
vsftpd-7977 [003] .... 577.180555: on_each_cpu <-_rcu_barrier.isra.31
vsftpd-7977 [003] d... 577.180561: rcu_barrier_func <-on_each_cpu
vsftpd-7977 [003] d... 577.180562: call_rcu_sched <-rcu_barrier_func
vsftpd-7977 [003] .... 577.180563: wait_for_completion <-_rcu_barrier.isra.31
ksoftirqd/3-16 [003] ..s. 577.180767: rcu_barrier_callback <-__rcu_process_callbacks
vsftpd-7977 [003] .... 577.184450: mutex_unlock <-_rcu_barrier.isra.31
vsftpd-7977 [003] .... 577.184565: rcu_barrier <-deactivate_locked_super
vsftpd-7977 [003] .... 577.184566: rcu_barrier_sched <-rcu_barrier
vsftpd-7977 [003] .... 577.184566: _rcu_barrier.isra.31 <-rcu_barrier_sched
vsftpd-7977 [003] .... 577.184566: mutex_lock <-_rcu_barrier.isra.31
vsftpd-7977 [003] .... 577.184566: __init_waitqueue_head <-_rcu_barrier.isra.31
vsftpd-7977 [003] .... 577.184567: on_each_cpu <-_rcu_barrier.isra.31
vsftpd-7977 [003] d... 577.184573: rcu_barrier_func <-on_each_cpu
vsftpd-7977 [003] d... 577.184573: call_rcu_sched <-rcu_barrier_func
vsftpd-7977 [003] .... 577.184573: wait_for_completion <-_rcu_barrier.isra.31
ksoftirqd/3-16 [003] ..s. 577.184733: rcu_barrier_callback <-__rcu_process_callbacks
vsftpd-7977 [003] .... 577.188430: mutex_unlock <-_rcu_barrier.isra.31
vsftpd-7977 [003] .... 577.188536: rcu_barrier <-deactivate_locked_super
vsftpd-7977 [003] .... 577.188536: rcu_barrier_sched <-rcu_barrier
vsftpd-7977 [003] .... 577.188536: _rcu_barrier.isra.31 <-rcu_barrier_sched
vsftpd-7977 [003] .... 577.188536: mutex_lock <-_rcu_barrier.isra.31
vsftpd-7977 [003] .... 577.188537: __init_waitqueue_head <-_rcu_barrier.isra.31
vsftpd-7977 [003] .... 577.188537: on_each_cpu <-_rcu_barrier.isra.31
vsftpd-7977 [003] d... 577.188555: rcu_barrier_func <-on_each_cpu
vsftpd-7977 [003] d... 577.188555: call_rcu_sched <-rcu_barrier_func
vsftpd-7977 [003] .... 577.188555: wait_for_completion <-_rcu_barrier.isra.31
ksoftirqd/3-16 [003] ..s. 577.188715: rcu_barrier_callback <-__rcu_process_callbacks
vsftpd-7977 [003] .... 577.192421: mutex_unlock <-_rcu_barrier.isra.31
vsftpd-7977 [003] .... 577.192527: rcu_barrier <-deactivate_locked_super
vsftpd-7977 [003] .... 577.192527: rcu_barrier_sched <-rcu_barrier
vsftpd-7977 [003] .... 577.192527: _rcu_barrier.isra.31 <-rcu_barrier_sched
vsftpd-7977 [003] .... 577.192527: mutex_lock <-_rcu_barrier.isra.31
vsftpd-7977 [003] .... 577.192528: __init_waitqueue_head <-_rcu_barrier.isra.31
vsftpd-7977 [003] .... 577.192528: on_each_cpu <-_rcu_barrier.isra.31
vsftpd-7977 [003] d... 577.192546: rcu_barrier_func <-on_each_cpu
vsftpd-7977 [003] d... 577.192546: call_rcu_sched <-rcu_barrier_func
vsftpd-7977 [003] .... 577.192547: wait_for_completion <-_rcu_barrier.isra.31
ksoftirqd/3-16 [003] ..s. 577.192731: rcu_barrier_callback <-__rcu_process_callbacks
ksoftirqd/3-16 [003] ..s. 577.192731: complete <-rcu_barrier_callback
vsftpd-7977 [003] .... 577.192750: mutex_unlock <-_rcu_barrier.isra.31
vsftpd-7977 [003] .... 577.192821: rcu_barrier <-deactivate_locked_super
vsftpd-7977 [003] .... 577.192821: rcu_barrier_sched <-rcu_barrier
vsftpd-7977 [003] .... 577.192821: _rcu_barrier.isra.31 <-rcu_barrier_sched
vsftpd-7977 [003] .... 577.192821: mutex_lock <-_rcu_barrier.isra.31
vsftpd-7977 [003] .... 577.192822: __init_waitqueue_head <-_rcu_barrier.isra.31
vsftpd-7977 [003] .... 577.192822: on_each_cpu <-_rcu_barrier.isra.31
vsftpd-7977 [003] d... 577.192832: rcu_barrier_func <-on_each_cpu
vsftpd-7977 [003] d... 577.192833: call_rcu_sched <-rcu_barrier_func
vsftpd-7977 [003] .... 577.192833: wait_for_completion <-_rcu_barrier.isra.31
ksoftirqd/3-16 [003] ..s. 577.196559: rcu_barrier_callback <-__rcu_process_callbacks
ksoftirqd/3-16 [003] ..s. 577.196560: complete <-rcu_barrier_callback
vsftpd-7977 [003] .... 577.196571: mutex_unlock <-_rcu_barrier.isra.31
vsftpd-7977 [003] .... 577.196642: rcu_barrier <-deactivate_locked_super
vsftpd-7977 [003] .... 577.196642: rcu_barrier_sched <-rcu_barrier
vsftpd-7977 [003] .... 577.196642: _rcu_barrier.isra.31 <-rcu_barrier_sched
vsftpd-7977 [003] .... 577.196642: mutex_lock <-_rcu_barrier.isra.31
vsftpd-7977 [003] .... 577.196643: __init_waitqueue_head <-_rcu_barrier.isra.31
vsftpd-7977 [003] .... 577.196643: on_each_cpu <-_rcu_barrier.isra.31
vsftpd-7977 [003] d... 577.196653: rcu_barrier_func <-on_each_cpu
vsftpd-7977 [003] d... 577.196654: call_rcu_sched <-rcu_barrier_func
vsftpd-7977 [003] .... 577.196654: wait_for_completion <-_rcu_barrier.isra.31
ksoftirqd/3-16 [003] ..s. 577.200577: rcu_barrier_callback <-__rcu_process_callbacks
ksoftirqd/3-16 [003] ..s. 577.200577: complete <-rcu_barrier_callback
vsftpd-7977 [003] .... 577.200589: mutex_unlock <-_rcu_barrier.isra.31
vsftpd-7977 [003] .... 577.200659: rcu_barrier <-deactivate_locked_super
vsftpd-7977 [003] .... 577.200659: rcu_barrier_sched <-rcu_barrier
vsftpd-7977 [003] .... 577.200659: _rcu_barrier.isra.31 <-rcu_barrier_sched
vsftpd-7977 [003] .... 577.200659: mutex_lock <-_rcu_barrier.isra.31
vsftpd-7977 [003] .... 577.200660: __init_waitqueue_head <-_rcu_barrier.isra.31
vsftpd-7977 [003] .... 577.200660: on_each_cpu <-_rcu_barrier.isra.31
vsftpd-7977 [003] d... 577.200671: rcu_barrier_func <-on_each_cpu
vsftpd-7977 [003] d... 577.200671: call_rcu_sched <-rcu_barrier_func
vsftpd-7977 [003] .... 577.200672: wait_for_completion <-_rcu_barrier.isra.31
ksoftirqd/3-16 [003] ..s. 577.204548: rcu_barrier_callback <-__rcu_process_callbacks
ksoftirqd/3-16 [003] ..s. 577.204548: complete <-rcu_barrier_callback
vsftpd-7977 [003] .... 577.204559: mutex_unlock <-_rcu_barrier.isra.31
vsftpd-7977 [003] .... 577.204630: rcu_barrier <-deactivate_locked_super
vsftpd-7977 [003] .... 577.204631: rcu_barrier_sched <-rcu_barrier
vsftpd-7977 [003] .... 577.204631: _rcu_barrier.isra.31 <-rcu_barrier_sched
vsftpd-7977 [003] .... 577.204631: mutex_lock <-_rcu_barrier.isra.31
vsftpd-7977 [003] .... 577.204631: __init_waitqueue_head <-_rcu_barrier.isra.31
vsftpd-7977 [003] .... 577.204631: on_each_cpu <-_rcu_barrier.isra.31
vsftpd-7977 [003] d... 577.204642: rcu_barrier_func <-on_each_cpu
vsftpd-7977 [003] d... 577.204642: call_rcu_sched <-rcu_barrier_func
vsftpd-7977 [003] .... 577.204643: wait_for_completion <-_rcu_barrier.isra.31
ksoftirqd/3-16 [003] ..s. 577.208511: rcu_barrier_callback <-__rcu_process_callbacks
ksoftirqd/3-16 [003] ..s. 577.208511: complete <-rcu_barrier_callback
vsftpd-7977 [003] .... 577.208523: mutex_unlock <-_rcu_barrier.isra.31
next prev parent reply other threads:[~2012-05-05 6:08 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-28 9:19 Mike Galbraith
2012-04-28 14:26 ` Oleg Nesterov
2012-04-29 4:13 ` Mike Galbraith
2012-04-29 7:57 ` Eric W. Biederman
2012-04-29 9:49 ` Mike Galbraith
2012-04-29 16:58 ` Oleg Nesterov
2012-04-30 2:59 ` Eric W. Biederman
2012-04-30 3:25 ` Mike Galbraith
2012-05-02 12:40 ` Oleg Nesterov
2012-05-02 17:37 ` Eric W. Biederman
2012-04-30 3:01 ` [PATCH] " Mike Galbraith
[not found] ` <m1zk9rmyh4.fsf@fess.ebiederm.org>
2012-05-01 20:42 ` Andrew Morton
2012-05-03 3:12 ` Mike Galbraith
2012-05-03 14:56 ` Mike Galbraith
2012-05-04 4:27 ` Mike Galbraith
2012-05-04 7:55 ` Eric W. Biederman
2012-05-04 8:34 ` Mike Galbraith
2012-05-04 9:45 ` Mike Galbraith
2012-05-04 14:13 ` Eric W. Biederman
2012-05-04 14:49 ` Mike Galbraith
2012-05-04 15:36 ` Eric W. Biederman
2012-05-04 16:57 ` Mike Galbraith
2012-05-04 20:29 ` Eric W. Biederman
2012-05-05 5:56 ` Mike Galbraith
2012-05-05 6:08 ` Mike Galbraith [this message]
2012-05-05 7:12 ` Mike Galbraith
2012-05-05 11:37 ` Eric W. Biederman
2012-05-07 21:51 ` [PATCH] vfs: Speed up deactivate_super for non-modular filesystems Eric W. Biederman
2012-05-07 22:17 ` Al Viro
2012-05-07 23:56 ` Paul E. McKenney
2012-05-08 1:07 ` Eric W. Biederman
2012-05-08 4:53 ` Mike Galbraith
2012-05-09 7:55 ` Nick Piggin
2012-05-09 11:02 ` Eric W. Biederman
2012-05-15 8:40 ` Nick Piggin
2012-05-16 0:34 ` Eric W. Biederman
2012-05-09 13:59 ` Paul E. McKenney
2012-05-04 8:03 ` [PATCH] Re: [RFC PATCH] namespaces: fix leak on fork() failure Eric W. Biederman
2012-05-04 8:19 ` Mike Galbraith
2012-05-04 8:54 ` Mike Galbraith
2012-05-07 0:32 ` [PATCH 0/3] pidns: Closing the pid namespace exit race Eric W. Biederman
2012-05-07 0:33 ` [PATCH 1/3] pidns: Use task_active_pid_ns in do_notify_parent Eric W. Biederman
2012-05-07 0:35 ` [PATCH 2/3] pidns: Guarantee that the pidns init will be the last pidns process reaped Eric W. Biederman
2012-05-08 22:50 ` Andrew Morton
2012-05-16 18:39 ` Oleg Nesterov
2012-05-16 19:34 ` Oleg Nesterov
2012-05-16 20:54 ` Eric W. Biederman
2012-05-17 17:00 ` Oleg Nesterov
2012-05-17 21:46 ` Eric W. Biederman
2012-05-18 12:39 ` Oleg Nesterov
2012-05-19 0:03 ` Eric W. Biederman
2012-05-21 12:44 ` Oleg Nesterov
2012-05-22 0:16 ` Eric W. Biederman
2012-05-22 0:20 ` [PATCH] pidns: Guarantee that the pidns init will be the last pidns process reaped. v2 Eric W. Biederman
2012-05-22 16:54 ` Oleg Nesterov
2012-05-22 19:23 ` Andrew Morton
2012-05-23 14:52 ` Oleg Nesterov
2012-05-25 15:15 ` [PATCH -mm] pidns-guarantee-that-the-pidns-init-will-be-the-last-pidns-process-r eaped-v2-fix-fix Oleg Nesterov
2012-05-25 15:59 ` [PATCH -mm 0/1] pidns: find_new_reaper() can no longer switch to init_pid_ns.child_reaper Oleg Nesterov
2012-05-25 16:00 ` [PATCH -mm 1/1] " Oleg Nesterov
2012-05-25 21:43 ` Eric W. Biederman
2012-05-27 19:10 ` [PATCH v2 -mm 0/1] " Oleg Nesterov
2012-05-27 19:11 ` [PATCH v2 -mm 1/1] " Oleg Nesterov
2012-05-29 6:34 ` Eric W. Biederman
2012-05-25 21:25 ` [PATCH -mm] pidns-guarantee-that-the-pidns-init-will-be-the-last-pidns-process-r eaped-v2-fix-fix Eric W. Biederman
2012-05-27 18:41 ` [PATCH -mm v2] " Oleg Nesterov
2012-05-07 0:35 ` [PATCH 3/3] pidns: Make killed children autoreap Eric W. Biederman
2012-05-08 22:51 ` Andrew Morton
2012-04-30 13:57 ` [RFC PATCH] namespaces: fix leak on fork() failure Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336198093.7346.11.camel@marge.simpson.net \
--to=efault@gmx.de \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=gorcunov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=louis.rilling@kerlabs.com \
--cc=oleg@redhat.com \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome