mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Michal Marek <mmarek@suse.cz>
Cc: linux-kbuild <linux-kbuild@vger.kernel.org>,
	lkml <linux-kernel@vger.kernel.org>,
	Artem Bityutskiy <artem.bityutskiy@linux.intel.com>,
	Sam Ravnborg <sam@ravnborg.org>
Subject: [PATCH 8/8] kbuild: remove useless warning
Date: Sat,  5 May 2012 10:18:46 +0200	[thread overview]
Message-ID: <1336205926-13946-8-git-send-email-sam@ravnborg.org> (raw)
In-Reply-To: <20120505080640.GA13773@merkur.ravnborg.org>

From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>

This patch removes annoying warning:

Makefile:708: "WARNING: Appending $KCFLAGS (-Wno-sign-compare) from command line to kernel $CFLAGS"

which is printed every time I use KCFLAFS. The commit which introduced the
warning:

69ee0b3 kbuild: do not pick up CFLAGS from the environment

tells about the problems when people have CFLAGS in their environment,
then switches to KCFLAFS which should be enough to solve the issue, but
it anyway introduces a warning. I think it is too much and I find this
warning very annoying - why should we warn users when they use the
build system properly?

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
 scripts/Kbuild.arch |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)

diff --git a/scripts/Kbuild.arch b/scripts/Kbuild.arch
index 6ff27c6..7841825 100644
--- a/scripts/Kbuild.arch
+++ b/scripts/Kbuild.arch
@@ -127,20 +127,13 @@ KBUILD_CFLAGS += $(warning)
 endif
 
 # Add user supplied CPPFLAGS, AFLAGS and CFLAGS as the last assignments
-# But warn user when we do so
-warn-assign = \
-$(warning "WARNING: Appending $$K$(1) ($(K$(1))) from $(origin K$(1)) to kernel $$$(1)")
-
 ifneq ($(KCPPFLAGS),)
-        $(call warn-assign,CPPFLAGS)
         KBUILD_CPPFLAGS += $(KCPPFLAGS)
 endif
 ifneq ($(KAFLAGS),)
-        $(call warn-assign,AFLAGS)
         KBUILD_AFLAGS += $(KAFLAGS)
 endif
 ifneq ($(KCFLAGS),)
-        $(call warn-assign,CFLAGS)
         KBUILD_CFLAGS += $(KCFLAGS)
 endif
 
-- 
1.6.0.6


  parent reply	other threads:[~2012-05-05  8:19 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-05  8:06 [PATCH 0/8] kbuild: use script for final link, move definitions out of top-level Makefile Sam Ravnborg
2012-05-05  8:18 ` [PATCH 1/8] kbuild: drop unused KBUILD_VMLINUX_OBJS from " Sam Ravnborg
2012-05-05  8:18 ` [PATCH 2/8] kbuild: refactor final link of sparc32 Sam Ravnborg
2012-05-05  8:18 ` [PATCH 3/8] kbuild: link of vmlinux moved to a script Sam Ravnborg
2012-05-05  8:18 ` [PATCH 4/8] kbuild: document KBUILD_LDS, KBUILD_VMLINUX_{INIT,MAIN} and LDFLAGS_vmlinux Sam Ravnborg
2012-05-05  8:18 ` [PATCH 5/8] kbuild: move definitions from top-level Makefile to scripts/Kbuild.config Sam Ravnborg
2012-06-26  9:37   ` Michal Marek
2012-06-26 10:18   ` Michal Marek
2012-05-05  8:18 ` [PATCH 6/8] kbuild: move arch definitions from top-level Makefile to scripts/Kbuild.arch Sam Ravnborg
2012-06-26 10:33   ` Michal Marek
2012-05-05  8:18 ` [PATCH 7/8] kbuild: move W=... stuff to Kbuild.arch Sam Ravnborg
2012-05-05  9:51   ` Artem Bityutskiy
2012-06-06 10:18   ` Artem Bityutskiy
2012-06-06 15:35     ` Sam Ravnborg
2012-06-06 15:46       ` Artem Bityutskiy
2012-08-15  9:41       ` Artem Bityutskiy
2012-08-15 10:17         ` Sam Ravnborg
2012-06-26 10:37   ` Michal Marek
2012-05-05  8:18 ` Sam Ravnborg [this message]
2012-05-07  6:59   ` [PATCH 8/8] kbuild: remove useless warning Artem Bityutskiy
2012-06-26 10:40   ` Michal Marek
2012-05-05 19:28 ` [PATCH 0/8] kbuild: use script for final link, move definitions out of top-level Makefile Michal Marek
2012-05-05 21:03   ` Sam Ravnborg
2012-05-16  4:52   ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1336205926-13946-8-git-send-email-sam@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=artem.bityutskiy@linux.intel.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®