mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: gregkh@linuxfoundation.org, dan.magenheimer@oracle.com,
	sjenning@linux.vnet.ibm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ramster: depend on CONFIG_NET for sock_* functions
Date: Mon, 07 May 2012 10:10:05 +0200	[thread overview]
Message-ID: <1336378205.1933.3.camel@x61.thuisdomein> (raw)
In-Reply-To: <1336377752-23985-1-git-send-email-levinsasha928@gmail.com>

On Mon, 2012-05-07 at 10:02 +0200, Sasha Levin wrote:
> Building ramster without CONFIG_NET would cause linkage issue due to missing

I'd say s/CONFIG_NET/NET/ 

> sock_*() functions in cluster/tcp.c
> 
> Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
> ---
>  drivers/staging/ramster/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/staging/ramster/Kconfig b/drivers/staging/ramster/Kconfig
> index 4af1f8d..8e334cb 100644
> --- a/drivers/staging/ramster/Kconfig
> +++ b/drivers/staging/ramster/Kconfig
> @@ -1,6 +1,6 @@
>  config RAMSTER
>  	bool "Cross-machine RAM capacity sharing, aka peer-to-peer tmem"
> -	depends on (CLEANCACHE || FRONTSWAP) && CONFIGFS_FS=y && !ZCACHE && !XVMALLOC && !HIGHMEM
> +	depends on (CLEANCACHE || FRONTSWAP) && CONFIGFS_FS=y && !ZCACHE && !XVMALLOC && !HIGHMEM && CONFIG_NET

s/CONFIG_NET/NET/ again, I'd say. How was this tested?

>  	select LZO_COMPRESS
>  	select LZO_DECOMPRESS
>  	default n


Paul Bolle


  reply	other threads:[~2012-05-07  8:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-07  8:02 Sasha Levin
2012-05-07  8:10 ` Paul Bolle [this message]
2012-05-07  8:29   ` Sasha Levin
2012-05-07  8:43     ` Paul Bolle
2012-05-07  8:47       ` Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1336378205.1933.3.camel@x61.thuisdomein \
    --to=pebolle@tiscali.nl \
    --cc=dan.magenheimer@oracle.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=levinsasha928@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sjenning@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®