From: Steven Rostedt <rostedt@goodmis.org>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>,
"H. Peter Anvin" <hpa@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Subject: Re: [PATCH][GIT PULL] ftrace/x86: Use asm/kprobes.h instead of linux/kprobes.h
Date: Mon, 07 May 2012 12:53:57 -0400 [thread overview]
Message-ID: <1336409637.14207.153.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <1336139384.14207.114.camel@gandalf.stny.rr.com>
Bah, I forgot to update the subject (fixed)
Anyway, Ingo, can you pull this.
Thanks!
-- Steve
On Fri, 2012-05-04 at 09:49 -0400, Steven Rostedt wrote:
> Ingo,
>
> This is based on top of tip/perf/core-3, and fixes the compile error
> that you saw with CONFIG_KPROBES disabled.
>
> Please pull the latest tip/perf/core-4 tree, which can be found at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git
> tip/perf/core-4
>
> Head SHA1: 59a094c994a138049b41a44bc29cff9407d51c5b
>
>
> Steven Rostedt (1):
> ftrace/x86: Use asm/kprobes.h instead of linux/kprobes.h
>
> ----
> arch/x86/kernel/ftrace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> ---------------------------
> commit 59a094c994a138049b41a44bc29cff9407d51c5b
> Author: Steven Rostedt <srostedt@redhat.com>
> Date: Fri May 4 09:26:16 2012 -0400
>
> ftrace/x86: Use asm/kprobes.h instead of linux/kprobes.h
>
> If CONFIG_KPROBES is not set, then linux/kprobes.h will not include
> asm/kprobes.h needed by x86/ftrace.c for the BREAKPOINT macro.
>
> The x86/ftrace.c file should just include asm/kprobes.h as it does not
> need the rest of kprobes.
>
> Reported-by: Ingo Molnar <mingo@elte.hu>
> Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
>
> diff --git a/arch/x86/kernel/ftrace.c b/arch/x86/kernel/ftrace.c
> index cf2d03e..4243e8b 100644
> --- a/arch/x86/kernel/ftrace.c
> +++ b/arch/x86/kernel/ftrace.c
> @@ -20,11 +20,11 @@
> #include <linux/init.h>
> #include <linux/list.h>
> #include <linux/module.h>
> -#include <linux/kprobes.h>
>
> #include <trace/syscall.h>
>
> #include <asm/cacheflush.h>
> +#include <asm/kprobes.h>
> #include <asm/ftrace.h>
> #include <asm/nops.h>
>
>
prev parent reply other threads:[~2012-05-07 16:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-04 13:49 [PATCH][GIT PULL] Steven Rostedt
2012-05-07 16:53 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336409637.14207.153.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=hpa@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®