From: Paul Bolle <pebolle@tiscali.nl>
To: "James E.J. Bottomley" <JBottomley@parallels.com>,
Matthew Dharm <mdharm-usb@one-eyed-alien.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-scsi@vger.kernel.org, usb-storage@lists.one-eyed-alien.net,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/3] scsi: usb-storage: hide errors for five devices
Date: Tue, 08 May 2012 12:19:06 +0200 [thread overview]
Message-ID: <1336472346.1933.52.camel@x61.thuisdomein> (raw)
0) Five USB memory sticks I happen to have will generate sets of two
errors when inserted. These sets are either:
[...] Asking for cache data failed
[...] Assuming drive cache: write through
or:
[...] No Caching mode page present
[...] Assuming drive cache: write through
These errors are generated by the SCSI stack (and printed thrice).
1) These patches try to hide those errors by:
- downgrading one error to a notice; and
- setting the NO_WP_DETECT quirk for these five devices.
2) Review of these patches is appreciated. Please note that the first
patch downgrades the error also for code paths that I apparently never
trigger, so that one especially needs additional thought, testing, etc.
3) It's not entirely clear which names one should use in the
UNUSUAL_DEV() macro. I just picked the most neutral names that showed up
for the devices in the logs.
4) Tested on v3.3.4, but applies cleanly to v3.4-rc6.
Paul Bolle (3):
scsi: downgrade "write through" error to notice
usb-storage: use NO_WP_DETECT for two devices
usb-storage: use NO_WP_DETECT for three devices
drivers/scsi/sd.c | 2 +-
drivers/usb/storage/unusual_devs.h | 22 ++++++++++++++++++++--
2 files changed, 21 insertions(+), 3 deletions(-)
--
1.7.7.6
next reply other threads:[~2012-05-08 10:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-08 10:19 Paul Bolle [this message]
2012-05-08 14:02 ` Alan Stern
2012-05-08 15:37 ` Paul Bolle
2012-05-08 17:03 ` Alan Stern
2012-05-15 15:35 ` Greg Kroah-Hartman
2012-05-15 16:29 ` Paul Bolle
2012-05-15 16:36 ` Alan Cox
2012-05-22 8:48 ` Paul Bolle
2012-05-22 9:25 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336472346.1933.52.camel@x61.thuisdomein \
--to=pebolle@tiscali.nl \
--cc=JBottomley@parallels.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mdharm-usb@one-eyed-alien.net \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®