mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Fenghua Yu" <fenghua.yu@intel.com>
To: "Ingo Molnar" <mingo@elte.hu>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"H Peter Anvin" <hpa@zytor.com>,
	"Linus Torvalds" <torvalds@linux-foundation.org>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Asit K Mallick" <asit.k.mallick@intel.com>,
	"Tony Luck" <tony.luck@intel.com>,
	"Arjan Dan De Ven" <arjan@linux.intel.com>,
	"Suresh B Siddha" <suresh.b.siddha@intel.com>,
	"Len Brown" <len.brown@intel.com>,
	"Srivatssa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>,
	"Randy Dunlap" <rdunlap@xenotime.net>,
	"Chen Gong" <gong.chen@linux.intel.com>,
	"linux-kernel" <linux-kernel@vger.kernel.org>,
	"linux-pm" <linux-pm@vger.kernel.org>, "x86" <x86@kernel.org>
Cc: "Fenghua Yu" <fenghua.yu@intel.com>
Subject: [PATCH v6 05/12] x86/power/cpu.c: Don't hibernate/suspend if CPU0 is offline
Date: Thu, 10 May 2012 09:16:47 -0700	[thread overview]
Message-ID: <1336666614-21090-6-git-send-email-fenghua.yu@intel.com> (raw)
In-Reply-To: <1336666614-21090-1-git-send-email-fenghua.yu@intel.com>

From: Fenghua Yu <fenghua.yu@intel.com>

Because x86 BIOS requires CPU0 to resume from sleep, suspend or hibernate
can't be executed if CPU0 is detected offline. To make suspend or hibernate and
further resume succeed, CPU0 must be online.

Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
---
 arch/x86/power/cpu.c |   44 ++++++++++++++++++++++++++++++++++++++++++++
 1 files changed, 44 insertions(+), 0 deletions(-)

diff --git a/arch/x86/power/cpu.c b/arch/x86/power/cpu.c
index 218cdb1..3338609 100644
--- a/arch/x86/power/cpu.c
+++ b/arch/x86/power/cpu.c
@@ -237,3 +237,47 @@ void restore_processor_state(void)
 #ifdef CONFIG_X86_32
 EXPORT_SYMBOL(restore_processor_state);
 #endif
+
+/*
+ * When bsp_check() is called in hibernate and suspend, cpu hotplug
+ * is disabled already. So it's unnessary to handle race condition between
+ * cpumask query and cpu hotplug.
+ */
+static int bsp_check(void)
+{
+	if (cpumask_first(cpu_online_mask) != 0) {
+		printk(KERN_WARNING "CPU0 is offline.\n");
+		return -ENODEV;
+	}
+
+	return 0;
+}
+
+static int bsp_pm_callback(struct notifier_block *nb, unsigned long action,
+			   void *ptr)
+{
+	int ret = 0;
+
+	switch (action) {
+	case PM_SUSPEND_PREPARE:
+	case PM_HIBERNATION_PREPARE:
+		ret = bsp_check();
+		break;
+	default:
+		break;
+	}
+	return notifier_from_errno(ret);
+}
+
+static int __init bsp_pm_check_init(void)
+{
+	/*
+	 * Set this bsp_pm_callback as lower priority than
+	 * cpu_hotplug_pm_callback. So cpu_hotplug_pm_callback will be called
+	 * earlier to disable cpu hotplug before bsp online check.
+	 */
+	pm_notifier(bsp_pm_callback, -INT_MAX);
+	return 0;
+}
+
+core_initcall(bsp_pm_check_init);
-- 
1.6.0.3


  parent reply	other threads:[~2012-05-10 16:32 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-10 16:16 [PATCH v6 0/12] x86: Arbitrary CPU hot(un)plug support Fenghua Yu
2012-05-10 16:16 ` [PATCH v6 01/12] Documentations/cpu-hotplug.tx, kernel-parameters.txt: Add x86 CPU0 online/offline feature Fenghua Yu
2012-05-10 16:16 ` [PATCH v6 02/12] x86/Kconfig: Add config switch for CPU0 hotplug Fenghua Yu
2012-05-10 16:16 ` [PATCH v6 03/12] x86/topology.c: Support functions for CPU0 online/offline Fenghua Yu
2012-05-10 16:16 ` [PATCH v6 04/12] x86/smpboot.c: Don't offline CPU0 if any irq can not be migrated out of it and remove CPU0 check in smp_callin() Fenghua Yu
2012-05-11 12:05   ` Thomas Gleixner
2012-05-11 18:42     ` Tony Luck
2012-05-14 12:17       ` Ingo Molnar
2012-05-14 16:40         ` Luck, Tony
2012-05-14 20:03           ` Yu, Fenghua
2012-05-17 22:47         ` Suresh Siddha
2012-05-18  1:47           ` Yu, Fenghua
2012-05-18  3:34             ` H. Peter Anvin
2012-05-17 22:52         ` H. Peter Anvin
2012-05-18  6:46           ` Ingo Molnar
2012-05-10 16:16 ` Fenghua Yu [this message]
2012-05-10 16:16 ` [PATCH v6 06/12] x86/head_64.S: Define start_cpu0 Fenghua Yu
2012-05-10 16:16 ` [PATCH v6 07/12] x86/head_32.S: " Fenghua Yu
2012-05-10 17:31   ` H. Peter Anvin
2012-05-10 20:48     ` Yu, Fenghua
2012-05-10 23:53       ` H. Peter Anvin
2012-05-10 16:16 ` [PATCH v6 08/12] x86/smpboot.c: Wake up CPU0 via NMI instead of INITs Fenghua Yu
2012-05-10 16:16 ` [PATCH v6 09/12] x86/common.c: Init CPU0 data during CPU0 online Fenghua Yu
2012-05-10 16:16 ` [PATCH v6 10/12] x86/mtrr/main.c: Ask the first online CPU to save mtrr Fenghua Yu
2012-05-10 16:16 ` [PATCH v6 11/12] x86/i387.c: Thread xstate is initialized only on CPU0 once Fenghua Yu
2012-05-10 16:16 ` [PATCH v6 12/12] x86/topology.c: debug CPU0 hotplug Fenghua Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1336666614-21090-6-git-send-email-fenghua.yu@intel.com \
    --to=fenghua.yu@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=arjan@linux.intel.com \
    --cc=asit.k.mallick@intel.com \
    --cc=gong.chen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rdunlap@xenotime.net \
    --cc=srivatsa.bhat@linux.vnet.ibm.com \
    --cc=suresh.b.siddha@intel.com \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®