From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946261Ab2EKV65 (ORCPT ); Fri, 11 May 2012 17:58:57 -0400 Received: from mail.linux-iscsi.org ([67.23.28.174]:45679 "EHLO linux-iscsi.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758746Ab2EKV6z (ORCPT ); Fri, 11 May 2012 17:58:55 -0400 Subject: Re: [GIT PULL] target fixes for v3.4-rc7 From: "Nicholas A. Bellinger" To: Linus Torvalds Cc: target-devel , linux-scsi , LKML In-Reply-To: <1336773136.25759.167.camel@haakon2.linux-iscsi.org> References: <1336773136.25759.167.camel@haakon2.linux-iscsi.org> Content-Type: text/plain; charset="UTF-8" Date: Fri, 11 May 2012 14:58:54 -0700 Message-ID: <1336773534.25759.170.camel@haakon2.linux-iscsi.org> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2012-05-11 at 14:52 -0700, Nicholas A. Bellinger wrote: > Hi Linus ! > > This time around for -rc7, there is only a single outstanding target > pending bugfix ready to be merged.. > > Please go ahead and pull from: > > git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git 3.4-urgent > > This patch removes some incorrect legacy code to free se_lun_acl memory > in the NodeACL release path that could potentially trigger an OOPs > during shutdown once dynamic -> explicit initiator NodeACL conversion > has occurred. > > That said, we've been able to trigger an OOPs in v4.0 code for this > special case when the associated MappedLUNs had not also been made > explicit based on active TPG LUN layout during the conversion, so it > really makes senses to go ahead and drop this extra cruft to avoid any > possible issues here. > > This ends up only effecting iscsi-target module code (it's the only > user) and is CC'ed to stable. > > Thanks! > > --nab > > Nicholas Bellinger (1): > target: Drop incorrect se_lun_acl release for dynamic -> explict ACL > conversion > > drivers/target/target_core_tpg.c | 21 --------------------- > 1 files changed, 0 insertions(+), 21 deletions(-) > Whoops sorry, missed the now unused variables in this patch.. Here is the updated diff-stat for target-pending/3.4-urgent drivers/target/target_core_tpg.c | 22 ---------------------- 1 files changed, 0 insertions(+), 22 deletions(-) Thanks, --nab