From: Joe Perches <joe@perches.com>
To: Namjae Jeon <linkinjeon@gmail.com>
Cc: hirofumi@mail.parknet.co.jp, linux-kernel@vger.kernel.org,
Amit Sahrawat <amit.sahrawat83@gmail.com>
Subject: Re: [PATCH 2/2] fat: use fat_msg_ratelimit in fat__get_entry.
Date: Sun, 13 May 2012 08:46:51 -0700 [thread overview]
Message-ID: <1336924011.31383.6.camel@joe2Laptop> (raw)
In-Reply-To: <1336907039-18638-1-git-send-email-linkinjeon@gmail.com>
On Sun, 2012-05-13 at 07:03 -0400, Namjae Jeon wrote:
> So this patch use fat_msg_ratelimit function about this message to decrease this messages.
[]
> diff --git a/fs/fat/dir.c b/fs/fat/dir.c
> index aca191b..b2cdbf4 100644
> --- a/fs/fat/dir.c
> +++ b/fs/fat/dir.c
> @@ -98,8 +98,8 @@ next:
>
> *bh = sb_bread(sb, phys);
> if (*bh == NULL) {
> - fat_msg(sb, KERN_ERR, "Directory bread(block %llu) failed",
> - (llu)phys);
> + fat_msg_ratelimit(sb, KERN_ERR, "Directory bread(block %llu) "
> + "failed", (llu)phys);
Please don't split format strings.
It's much harder to grep.
next prev parent reply other threads:[~2012-05-13 15:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-13 11:03 Namjae Jeon
2012-05-13 14:24 ` OGAWA Hirofumi
2012-05-13 15:46 ` Joe Perches [this message]
2012-05-13 16:07 ` OGAWA Hirofumi
2012-05-13 16:21 ` Joe Perches
2012-05-13 16:39 ` OGAWA Hirofumi
2012-05-13 23:03 ` Namjae Jeon
2012-05-15 14:46 Namjae Jeon
2012-05-15 15:11 ` OGAWA Hirofumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336924011.31383.6.camel@joe2Laptop \
--to=joe@perches.com \
--cc=amit.sahrawat83@gmail.com \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linkinjeon@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®