From: Dong Aisheng <b29396@freescale.com>
To: <linux-kernel@vger.kernel.org>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linus.walleij@stericsson.com>, <swarren@wwwdotorg.org>,
<haojian.zhuang@marvell.com>, <shawn.guo@freescale.com>
Subject: [PATCH 1/5] pinctrl: a minor error checking improvement for pinconf
Date: Mon, 14 May 2012 19:06:36 +0800 [thread overview]
Message-ID: <1336993600-30065-1-git-send-email-b29396@freescale.com> (raw)
From: Dong Aisheng <dong.aisheng@linaro.org>
Also checking invalid num_configs when validate the pinconf map.
Signed-off-by: Dong Aisheng <dong.aisheng@linaro.org>
---
drivers/pinctrl/pinconf.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/pinconf.c b/drivers/pinctrl/pinconf.c
index 7ce139e..43f474c 100644
--- a/drivers/pinctrl/pinconf.c
+++ b/drivers/pinctrl/pinconf.c
@@ -50,9 +50,9 @@ int pinconf_validate_map(struct pinctrl_map const *map, int i)
return -EINVAL;
}
- if (map->data.configs.num_configs &&
+ if (!map->data.configs.num_configs ||
!map->data.configs.configs) {
- pr_err("failed to register map %s (%d): no configs ptr given\n",
+ pr_err("failed to register map %s (%d): no configs given\n",
map->name, i);
return -EINVAL;
}
--
1.7.0.4
next reply other threads:[~2012-05-14 11:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 11:06 Dong Aisheng [this message]
2012-05-14 11:06 ` [PATCH 2/5] pinctrl: make pinmux disable function optional Dong Aisheng
2012-05-15 7:45 ` Linus Walleij
2012-05-14 11:06 ` [PATCH 3/5] pinctrl: pinctrl-imx: remove empty pinmux disable function Dong Aisheng
2012-05-15 7:47 ` Linus Walleij
2012-05-14 11:06 ` [PATCH 4/5] pinctrl: pinctrl-mxs: " Dong Aisheng
2012-05-15 7:48 ` Linus Walleij
2012-05-14 11:06 ` [PATCH 5/5] pinctrl: pinctrl-pxa3xx: " Dong Aisheng
2012-05-15 8:00 ` Linus Walleij
2012-05-14 23:31 ` [PATCH 1/5] pinctrl: a minor error checking improvement for pinconf Stephen Warren
2012-05-15 7:44 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336993600-30065-1-git-send-email-b29396@freescale.com \
--to=b29396@freescale.com \
--cc=haojian.zhuang@marvell.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shawn.guo@freescale.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®