From: <sonic.zhang@analog.com>
To: Ben Dooks <ben-linux@fluff.org>, Wolfram Sang <w.sang@pengutronix.de>
Cc: <linux-i2c@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>,
<uclinux-dist-devel@blackfin.uclinux.org>,
Sonic Zhang <sonic.zhang@analog.com>
Subject: [PATCH 4/8] i2c: i2c-bfin-twi: Tighten condition when failing I2C transfer if MEN bit is reset unexpectedly.
Date: Wed, 16 May 2012 15:20:22 +0800 [thread overview]
Message-ID: <1337152826-9850-4-git-send-email-sonic.zhang@analog.com> (raw)
In-Reply-To: <1337152826-9850-1-git-send-email-sonic.zhang@analog.com>
From: Sonic Zhang <sonic.zhang@analog.com>
Correct I2C transfer may fail because interrupt status bits XMTSERV and
RCVSERV are not checked when MCOMP interrupt is handled.
Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>
---
drivers/i2c/busses/i2c-bfin-twi.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/i2c/busses/i2c-bfin-twi.c b/drivers/i2c/busses/i2c-bfin-twi.c
index 4abaf59..63fb84f 100644
--- a/drivers/i2c/busses/i2c-bfin-twi.c
+++ b/drivers/i2c/busses/i2c-bfin-twi.c
@@ -201,7 +201,8 @@ static void bfin_twi_handle_interrupt(struct bfin_twi_iface *iface,
return;
}
if (twi_int_status & MCOMP) {
- if ((read_MASTER_CTL(iface) & MEN) == 0 &&
+ if (twi_int_status & (XMTSERV|RCVSERV) &&
+ (read_MASTER_CTL(iface) & MEN) == 0 &&
(iface->cur_mode == TWI_I2C_MODE_REPEAT ||
iface->cur_mode == TWI_I2C_MODE_COMBINED)) {
iface->result = -1;
--
1.7.0.4
next prev parent reply other threads:[~2012-05-16 7:31 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-16 7:20 [PATCH 1/8] i2c: i2c-bfin-twi: Illegal i2c bus lock upon certain transfer scenarios sonic.zhang
2012-05-16 7:20 ` [PATCH 2/8] i2c: i2c-bfin-twi: Stop receiving operation immediately in last rx interrupt sonic.zhang
2012-05-24 9:18 ` Sonic Zhang
2012-06-11 16:28 ` Wolfram Sang
2012-05-16 7:20 ` [PATCH 3/8] i2c: i2c-bfin-twi: Break dead waiting loop if i2c device misbehaves sonic.zhang
2012-05-17 5:20 ` Shubhrajyoti Datta
2012-05-17 5:23 ` Mike Frysinger
2012-05-17 10:51 ` Shubhrajyoti Datta
2012-06-11 16:30 ` Wolfram Sang
2012-06-13 7:47 ` Zhang, Sonic
2012-05-16 7:20 ` sonic.zhang [this message]
2012-05-17 11:30 ` [PATCH 4/8] i2c: i2c-bfin-twi: Tighten condition when failing I2C transfer if MEN bit is reset unexpectedly Shubhrajyoti Datta
2012-05-18 2:41 ` Zhang, Sonic
2012-05-18 6:22 ` Shubhrajyoti Datta
2012-06-11 16:33 ` Wolfram Sang
2012-05-16 7:20 ` [PATCH 5/8] i2c:i2c-bfin-twi: TWI fails to restart next transfer in high system load sonic.zhang
2012-05-16 7:20 ` [PATCH 6/8] i2c:i2c-bfin-twi: include twi head file sonic.zhang
2012-05-24 9:18 ` Sonic Zhang
2012-06-11 16:34 ` Wolfram Sang
2012-05-16 7:20 ` [PATCH 7/8] i2c: i2c-bfin-twi: Move TWI peripheral pin request array to platform data sonic.zhang
2012-06-11 16:35 ` Wolfram Sang
2012-05-16 7:20 ` [PATCH 8/8] i2c: i2c-bfin-twi: Move blackfin TWI register access Macro to head file sonic.zhang
2012-05-24 9:19 ` Sonic Zhang
2012-05-25 9:48 ` Shubhrajyoti Datta
2012-05-25 9:54 ` Zhang, Sonic
2012-05-25 10:10 ` Shubhrajyoti Datta
2012-05-25 10:12 ` Zhang, Sonic
2012-05-25 10:16 ` Shubhrajyoti Datta
2012-06-11 16:36 ` Wolfram Sang
2012-05-24 9:17 ` [PATCH 1/8] i2c: i2c-bfin-twi: Illegal i2c bus lock upon certain transfer scenarios Sonic Zhang
2012-06-11 16:24 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337152826-9850-4-git-send-email-sonic.zhang@analog.com \
--to=sonic.zhang@analog.com \
--cc=ben-linux@fluff.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®