From: Steven Rostedt <rostedt@goodmis.org>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Arjan van de Ven <arjan@linux.intel.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>,
Frederic Weisbecker <fweisbec@gmail.com>,
David Sharp <dsharp@google.com>,
Vaibhav Nagarnaik <vnagarnaik@google.com>,
Peter Zijlstra <peterz@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: [RFC][PATCH] tracing: Remove useless 4 bytes of padding from every event
Date: Wed, 16 May 2012 09:44:31 -0400 [thread overview]
Message-ID: <1337175871.6724.46.camel@gandalf.stny.rr.com> (raw)
Now that PowerTop v2 is out, which uses the parse-event library, it no
longer is broken by the removal of the lock-depth field from every
event. Currently we add 4 bytes of empty space to every event. If we
have 1 million events, 4 million bytes are wasted in the ring buffers
(for both ftrace and perf).
But this change will break PowerTop v1. Thus my question is, how long do
we need to keep this wasted space in the ring buffers to satisfy an out
of date tool?
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
diff --git a/include/linux/ftrace_event.h b/include/linux/ftrace_event.h
index 5f3f3be..f96dfef 100644
--- a/include/linux/ftrace_event.h
+++ b/include/linux/ftrace_event.h
@@ -49,7 +49,6 @@ struct trace_entry {
unsigned char flags;
unsigned char preempt_count;
int pid;
- int padding;
};
#define FTRACE_MAX_EVENT \
next reply other threads:[~2012-05-16 13:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-16 13:44 Steven Rostedt [this message]
2012-05-16 17:24 ` [RFC][PATCH v2] " Steven Rostedt
2012-05-16 19:33 ` [RFC][PATCH] " Linus Torvalds
2012-05-16 19:36 ` Arjan van de Ven
2012-05-16 19:47 ` Steven Rostedt
2012-05-16 19:51 ` Linus Torvalds
2012-05-16 20:03 ` Steven Rostedt
2012-05-17 8:04 ` Ingo Molnar
2012-05-16 20:00 ` Steven Rostedt
2012-05-16 20:04 ` Linus Torvalds
2012-05-16 20:07 ` Arjan van de Ven
2012-05-16 20:13 ` Steven Rostedt
2012-05-16 20:14 ` Dave Jones
2012-05-16 20:16 ` Arjan van de Ven
2012-05-17 8:06 ` Ingo Molnar
2012-05-17 12:11 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337175871.6724.46.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=dsharp@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=vnagarnaik@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®