From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-kernel@vger.kernel.org,
Linuxppc-dev <linuxppc-dev@ozlabs.org>,
Parisc List <linux-parisc@vger.kernel.org>,
the arch/x86 maintainers <x86@kernel.org>,
Dmitry Kasatkin <dmitry.kasatkin@intel.com>,
James Morris <jmorris@namei.org>
Subject: Re: Build regressions/improvements in v3.4-rc7
Date: Wed, 16 May 2012 15:46:03 +0100 [thread overview]
Message-ID: <1337179563.2985.80.camel@dabdike.int.hansenpartnership.com> (raw)
In-Reply-To: <CAMuHMdUtL4_mv-e-EQAZmNcb9dAT=PXB59i7Vuj2vf8NnaBFzQ@mail.gmail.com>
On Wed, 2012-05-16 at 10:47 +0200, Geert Uytterhoeven wrote:
> On Wed, May 16, 2012 at 10:30 AM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
> + lib/mpi/generic_mpih-mul1.c: error: inconsistent operand
> constraints in an 'asm': => 50:70
> + lib/mpi/generic_mpih-mul2.c: error: inconsistent operand
> constraints in an 'asm': => 49:70
> + lib/mpi/generic_mpih-mul3.c: error: inconsistent operand
> constraints in an 'asm': => 49:70
> + lib/mpi/mpih-div.c: error: inconsistent operand constraints in an
> 'asm': => 135:122, 135:371, 97:122, 106:121, 106:370, 97:371
>
> parisc-allmodconfig
Wow, lib/mpi/ is a complete horror: it's full of hand crafted asm code.
The error in this case appears to be that umul_ppm() is implemented as
an xmpyu instruction. That's a floating point instruction. We
deliberately compile the kernel with floating point disabled because we
don't want to save and restore the floating point register file on each
context switch, hence the operand constraints are unsatisfiable.
It appears to be completely untested on non-x86 and to have been
imported via the security tree ... what are we supposed to do with this?
I thought the general principle was that asm code was really supposed to
be confined to the arch directories?
James
next prev parent reply other threads:[~2012-05-16 14:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-16 8:30 Geert Uytterhoeven
2012-05-16 8:47 ` Geert Uytterhoeven
2012-05-16 14:46 ` James Bottomley [this message]
2012-05-16 15:59 ` Kasatkin, Dmitry
2012-05-16 15:59 ` Geert Uytterhoeven
2012-05-17 0:27 ` John David Anglin
2012-05-16 23:51 ` Benjamin Herrenschmidt
2012-05-17 17:30 ` Timur Tabi
2012-05-17 17:52 ` Tabi Timur-B04825
2012-05-17 18:42 ` Geert Uytterhoeven
2012-05-17 18:44 ` Timur Tabi
2012-05-17 18:48 ` Scott Wood
2012-05-17 18:51 ` Timur Tabi
2012-05-17 18:42 ` Timur Tabi
2012-05-18 7:47 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337179563.2985.80.camel@dabdike.int.hansenpartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=dmitry.kasatkin@intel.com \
--cc=geert@linux-m68k.org \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®