From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Lee Duncan <lduncan@suse.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
kai.makisara@kolumbus.fi, jeffm@suse.com
Subject: Re: [PATCH 3/5] st: get rid of scsi_tapes array
Date: Thu, 17 May 2012 08:35:30 +0100 [thread overview]
Message-ID: <1337240130.2926.4.camel@dabdike.int.hansenpartnership.com> (raw)
In-Reply-To: <4FB476F3.5010404@suse.com>
On Wed, 2012-05-16 at 20:56 -0700, Lee Duncan wrote:
> st currently allocates an array to store pointers to all of the
> scsi_tape objects. It's used to discover available indexes to use as the
> base for the minor number selection and later to look up scsi_tape
> devices for character devices.
>
> We switch to using an IDR for minor selection and a pointer from
> st_modedef back to scsi_tape for the lookups.
>
> Signed-off-by: Jeff Mahoney <jeffm@suse.com>
> Reviewed-by: Lee Duncan <lduncan@suse.com>
This can't be Reviewed-by either. The signoff chain has to follow the
transmission path of the patch. If you send me Jeff's patches, you have
to add a signoff because you're a direct part of the transmission path.
If Jeff sends me them, then he can give you Reviewed-by because you're
not then in the direct transmission path. (Signoff is supposed to imply
reviewed by anyway, so the tagging is correct in either case).
James
next prev parent reply other threads:[~2012-05-17 7:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-17 3:56 Lee Duncan
2012-05-17 7:35 ` James Bottomley [this message]
2012-05-14 23:28 ` Lee Duncan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337240130.2926.4.camel@dabdike.int.hansenpartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=jeffm@suse.com \
--cc=kai.makisara@kolumbus.fi \
--cc=lduncan@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®