From: Steven Rostedt <rostedt@goodmis.org>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Roland Dreier <roland@kernel.org>, Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org
Subject: Re: lockdep false positive in double_lock_balance()?
Date: Fri, 18 May 2012 10:43:03 -0400 [thread overview]
Message-ID: <1337352183.6724.107.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <1337282386.4281.77.camel@twins>
On Thu, 2012-05-17 at 21:19 +0200, Peter Zijlstra wrote:
> Something like this should fix it I think..
>
>
> ---
> kernel/sched/rt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
> index c5565c3..b649108 100644
> --- a/kernel/sched/rt.c
> +++ b/kernel/sched/rt.c
> @@ -1556,7 +1556,7 @@ static struct rq *find_lock_lowest_rq(struct task_struct *task, struct rq *rq)
> task_running(rq, task) ||
> !task->on_rq)) {
>
> - raw_spin_unlock(&lowest_rq->lock);
> + double_unlock_balance(rq, lowest_rq);
Acked-by: Steven Rostedt <rostedt@goodmis.org>
-- Steve
> lowest_rq = NULL;
> break;
> }
next prev parent reply other threads:[~2012-05-18 14:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1335314100-532-1-git-send-email-roland@kernel.org>
[not found] ` <alpine.LSU.2.00.1204251411460.4188@eggly.anvils>
2012-05-16 20:00 ` Roland Dreier
2012-05-17 19:19 ` Peter Zijlstra
2012-05-18 14:43 ` Steven Rostedt [this message]
2012-05-18 16:42 ` Roland Dreier
2012-06-06 15:54 ` [tip:sched/urgent] sched/rt: Fix lockdep annotation within find_lock_lowest_rq() tip-bot for Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337352183.6724.107.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=roland@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®