From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965059Ab2EWD3w (ORCPT ); Tue, 22 May 2012 23:29:52 -0400 Received: from mga14.intel.com ([143.182.124.37]:22127 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753040Ab2EWD3u (ORCPT ); Tue, 22 May 2012 23:29:50 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.71,315,1320652800"; d="scan'208";a="146567302" Message-ID: <1337743841.14538.178.camel@ymzhang.sh.intel.com> Subject: Re: [PATCH] ipv4: fix the rcu race between free_fib_info and ip_route_output_slow From: Yanmin Zhang To: David Miller Cc: kunx.jiang@intel.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 23 May 2012 11:30:41 +0800 In-Reply-To: <20120522.232310.911242148705021745.davem@davemloft.net> References: <4FBB6105.2060808@intel.com> <20120522.151554.106838106733194160.davem@davemloft.net> <1337742123.14538.175.camel@ymzhang.sh.intel.com> <20120522.232310.911242148705021745.davem@davemloft.net> Organization: MCG Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.2- Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2012-05-22 at 23:23 -0400, David Miller wrote: > From: Yanmin Zhang > Date: Wed, 23 May 2012 11:02:03 +0800 > > > 1) Why does free_fib_info call call_rcu instead of releasing fi directly? > > I assume other cpu might be accessing it. nexthop_nh->nh_dev is in fi. > > If other cpu are accessing it, here resetting to NULL would cause other > > cpu panic. > > Because fib trie lookups are done with RCU locking, therefore we must > use RCU freeing to release the object. > > What I was trying to impart to you is that removing the NULL > assignment is wrong and that an alternative fix is warranted (hint: > consider moving something into the RCU release). Thanks for the explanation. How about the new patch posted in the end of previous reply? It does move the the resetting to RCU release. https://lkml.org/lkml/2012/5/22/558?