From: Ian Kent <ikent@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
autofs mailing list <autofs@linux.kernel.org>
Subject: Re: [PATCH] autofs4 - fix get_next_positive_subdir()
Date: Wed, 23 May 2012 15:22:01 +0800 [thread overview]
Message-ID: <1337757721.2225.8.camel@perseus.themaw.net> (raw)
In-Reply-To: <CA+55aFwCESHx0d+ZEe-zi3PS6mkMaMng75Dnfit93cTwhb5gSg@mail.gmail.com>
On Tue, 2012-05-22 at 19:53 -0700, Linus Torvalds wrote:
> On Tue, May 22, 2012 at 7:49 PM, Ian Kent <ikent@redhat.com> wrote:
> >
> > The locking for the list traversal in get_next_positive_subdir() is
> > wrong, so fix it.
>
> As an explanation, this kind of thing is totally useless. It doesn't
> actually give any information at all. It's like saying "change
> locking"
>
> What happened, and why? Why is the new nested spinlock ok and won't
> deadlock against other nested users? Wazzup?
It's good that you questioned this Linus.
Looking again at dput() I think the traversal still isn't quite right.
For a start the test for d_count 0 or positive and hashed can never be
true since the point of the change was to take the d_lock of the
d_subdirs dentry for the traversal.
I'll need to work on this some more, thanks.
Ian
next prev parent reply other threads:[~2012-05-23 7:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-23 2:49 Ian Kent
2012-05-23 2:53 ` Linus Torvalds
2012-05-23 6:19 ` Ian Kent
2012-05-23 7:22 ` Ian Kent [this message]
2012-05-23 7:30 ` Ian Kent
2012-05-23 9:03 ` Ian Kent
2012-08-06 1:37 Ian Kent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337757721.2225.8.camel@perseus.themaw.net \
--to=ikent@redhat.com \
--cc=autofs@linux.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®