mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Sascha Hauer <kernel@pengutronix.de>,
	Russell King <linux@arm.linux.org.uk>,
	Paul Mundt <lethal@linux-sh.org>,
	Magnus Damm <magnus.damm@gmail.com>,
	linux-arm-kernel@lists.infradead.org, linux-sh@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Drop superfluous setting of i2c_board_info.type
Date: Thu, 24 May 2012 18:40:26 +0200	[thread overview]
Message-ID: <1337877626.22505.30.camel@x61.thuisdomein> (raw)
In-Reply-To: <20120524162230.GU3710@pengutronix.de>

On Thu, 2012-05-24 at 18:22 +0200, Uwe Kleine-König wrote:
> On Thu, May 24, 2012 at 04:38:23PM +0200, Paul Bolle wrote:
> > 1) This is apparently legal. Doesn't gcc issue a warning for this?
> I wondered about that too, gcc doesn't even warn when the two values are
> different. See for example commit
> bd9e310dca15c9987256f67af19f9f42426e7493.

In that case it were two strings ("rtc-pcf8563" versus "pcf8563"). Why
should gcc care? Or is there something going on behind the scenes which
somehow depends on the contents of the string?
 
> >  arch/arm/mach-imx/mach-cpuimx35.c     |    1 -
> >  arch/arm/mach-imx/mach-cpuimx51sd.c   |    1 -
> I already submitted a patch for the imx bits with Message id
> 1335989287-10094-1-git-send-email-u.kleine-koenig@pengutronix.de.
> (e.g.
> http://mid.gmane.org/1335989287-10094-1-git-send-email-u.kleine-koenig@pengutronix.de)

Thanks. I missed that one, obviously. Should I just drop that part of
the patch and resend?

By the way, together with my previous patch (Message-ID
1337869829.22505.15.camel@x61.thuisdomein , probably not yet archived on
the web) we have found all instances of this issue, haven't we?

> Don't know if Sascha took it already. If he did, he didn't tell me.


Paul Bolle


  reply	other threads:[~2012-05-24 16:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-24 14:38 Paul Bolle
2012-05-24 14:59 ` Paul Mundt
2012-05-24 16:22 ` Uwe Kleine-König
2012-05-24 16:40   ` Paul Bolle [this message]
2012-05-29 17:22     ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1337877626.22505.30.camel@x61.thuisdomein \
    --to=pebolle@tiscali.nl \
    --cc=kernel@pengutronix.de \
    --cc=lethal@linux-sh.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=magnus.damm@gmail.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®