From: Pantelis Antoniou <panto@antoniou-consulting.com>
To: linux-kernel@vger.kernel.org
Cc: linux@arm.linux.org.uk, Russ.Dill@ti.com, mporter@ti.com,
Pantelis Antoniou <panto@antoniou-consulting.com>
Subject: [PATCH] [ARM] Unconditional call to smp_cross_call on UP crashes
Date: Thu, 24 May 2012 17:09:59 +0000 [thread overview]
Message-ID: <1337879399-9998-1-git-send-email-panto@antoniou-consulting.com> (raw)
omap2plus_defconfig builds with SMP & SMP_ON_UP set.
On beagle (which is UP) is_smp() returns false and we don't call
smp_init_cpus which in turn does not initialize smp_cross_call which
remains NULL.
When issuing a reboot we OOPS with a NULL dereference on stop smp_call.
Fixed by checking is_smp in smp_send_stop()
---
arch/arm/kernel/smp.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/arch/arm/kernel/smp.c b/arch/arm/kernel/smp.c
index 8f46446..2a61335 100644
--- a/arch/arm/kernel/smp.c
+++ b/arch/arm/kernel/smp.c
@@ -588,6 +588,10 @@ void smp_send_stop(void)
unsigned long timeout;
struct cpumask mask;
+ /* make sure we don't bother if not SMP */
+ if (!is_smp())
+ return;
+
cpumask_copy(&mask, cpu_online_mask);
cpumask_clear_cpu(smp_processor_id(), &mask);
smp_cross_call(&mask, IPI_CPU_STOP);
--
1.7.1
next reply other threads:[~2012-05-23 17:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-24 17:09 Pantelis Antoniou [this message]
2012-05-23 17:45 ` Russ Dill
2012-05-23 18:52 ` Russell King - ARM Linux
2012-05-23 19:17 ` Russell King - ARM Linux
2012-05-23 18:55 ` Porter, Matt
2012-05-24 19:38 Pantelis Antoniou
2012-05-24 19:50 Pantelis Antoniou
2012-05-24 16:17 ` Russell King - ARM Linux
2012-05-24 16:55 ` Pantelis Antoniou
2012-05-24 17:15 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337879399-9998-1-git-send-email-panto@antoniou-consulting.com \
--to=panto@antoniou-consulting.com \
--cc=Russ.Dill@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mporter@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®