From: Anton Vorontsov <anton.vorontsov@linaro.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kees Cook <keescook@chromium.org>,
Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
John Stultz <john.stultz@linaro.org>,
Shuah Khan <shuahkhan@gmail.com>,
arve@android.com, Rebecca Schultz Zavin <rebecca@android.com>,
Jesper Juhl <jj@chaosbits.net>,
Randy Dunlap <rdunlap@xenotime.net>,
Stephen Boyd <sboyd@codeaurora.org>,
Thomas Meyer <thomas@m3y3r.de>,
Andrew Morton <akpm@linux-foundation.org>,
Marco Stornelli <marco.stornelli@gmail.com>,
WANG Cong <xiyou.wangcong@gmail.com>,
linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
linaro-kernel@lists.linaro.org, patches@linaro.org,
kernel-team@android.com
Subject: [PATCH 10/11] pstore/platform: Make automatic updates interval configurable
Date: Sat, 26 May 2012 06:20:28 -0700 [thread overview]
Message-ID: <1338038429-21945-10-git-send-email-anton.vorontsov@linaro.org> (raw)
In-Reply-To: <20120526131747.GA15054@lizard>
There is no behavioural change, the default value is still 60 seconds.
Signed-off-by: Anton Vorontsov <anton.vorontsov@linaro.org>
Acked-by: Kees Cook <keescook@chromium.org>
---
fs/pstore/platform.c | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/fs/pstore/platform.c b/fs/pstore/platform.c
index 61461ed..34ca314 100644
--- a/fs/pstore/platform.c
+++ b/fs/pstore/platform.c
@@ -31,6 +31,7 @@
#include <linux/slab.h>
#include <linux/uaccess.h>
#include <linux/hardirq.h>
+#include <linux/jiffies.h>
#include <linux/workqueue.h>
#include "internal.h"
@@ -40,7 +41,10 @@
* whether the system is actually still running well enough
* to let someone see the entry
*/
-#define PSTORE_INTERVAL (60 * HZ)
+static int pstore_update_ms = 60000;
+module_param_named(update_ms, pstore_update_ms, int, 0600);
+MODULE_PARM_DESC(update_ms, "milliseconds before pstore updates its content "
+ "(default is 60000; -1 means runtime updates are disabled)");
static int pstore_new_entry;
@@ -231,8 +235,11 @@ int pstore_register(struct pstore_info *psi)
kmsg_dump_register(&pstore_dumper);
pstore_register_console();
- pstore_timer.expires = jiffies + PSTORE_INTERVAL;
- add_timer(&pstore_timer);
+ if (pstore_update_ms >= 0) {
+ pstore_timer.expires = jiffies +
+ msecs_to_jiffies(pstore_update_ms);
+ add_timer(&pstore_timer);
+ }
return 0;
}
@@ -291,7 +298,7 @@ static void pstore_timefunc(unsigned long dummy)
schedule_work(&pstore_work);
}
- mod_timer(&pstore_timer, jiffies + PSTORE_INTERVAL);
+ mod_timer(&pstore_timer, jiffies + msecs_to_jiffies(pstore_update_ms));
}
module_param(backend, charp, 0444);
--
1.7.9.2
next prev parent reply other threads:[~2012-05-26 13:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-26 13:17 [PATCH v5 0/11] Merge ram_console into pstore Anton Vorontsov
2012-05-26 13:20 ` [PATCH 01/11] pstore: Add console log messages support Anton Vorontsov
2012-05-26 13:20 ` [PATCH 02/11] pstore/ram: Give proper names to dump-related variables Anton Vorontsov
2012-05-30 17:57 ` Kees Cook
2012-05-26 13:20 ` [PATCH 03/11] pstore/ram: Factor dmesg przs initialization out of probe() Anton Vorontsov
2012-05-29 7:32 ` Stephen Boyd
2012-05-26 13:20 ` [PATCH 04/11] pstore/ram: Factor ramoops_get_next_prz() out of ramoops_pstore_read() Anton Vorontsov
2012-05-30 17:58 ` Kees Cook
2012-05-26 13:20 ` [PATCH 05/11] pstore/ram: Add console messages handling Anton Vorontsov
2012-05-26 13:20 ` [PATCH 06/11] pstore/ram_core: Silence some printks Anton Vorontsov
2012-05-26 13:20 ` [PATCH 07/11] pstore/ram: Add some more documentation and examples Anton Vorontsov
2012-05-26 13:20 ` [PATCH 08/11] staging/android: Remove ram_console driver Anton Vorontsov
2012-05-26 13:20 ` [PATCH 09/11] pstore/ram_core: Remove now unused code Anton Vorontsov
2012-05-26 13:20 ` Anton Vorontsov [this message]
2012-05-26 13:20 ` [PATCH 11/11] pstore/platform: Disable automatic updates by default Anton Vorontsov
2012-06-14 0:05 ` [PATCH v5 0/11] Merge ram_console into pstore Greg Kroah-Hartman
2012-06-14 0:12 ` John Stultz
2012-06-14 0:20 ` Greg Kroah-Hartman
2012-06-14 0:29 ` John Stultz
2012-06-14 0:35 ` Anton Vorontsov
2012-06-14 0:22 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338038429-21945-10-git-send-email-anton.vorontsov@linaro.org \
--to=anton.vorontsov@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=arve@android.com \
--cc=ccross@android.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jj@chaosbits.net \
--cc=john.stultz@linaro.org \
--cc=keescook@chromium.org \
--cc=kernel-team@android.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marco.stornelli@gmail.com \
--cc=patches@linaro.org \
--cc=rdunlap@xenotime.net \
--cc=rebecca@android.com \
--cc=sboyd@codeaurora.org \
--cc=shuahkhan@gmail.com \
--cc=thomas@m3y3r.de \
--cc=tony.luck@intel.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®