From: Dimitrios Semitsoglou-Tsiapos <dimitrios.semitsoglou@gmail.com>
To: gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Dimitrios Semitsoglou-Tsiapos <dimitrios.semitsoglou@gmail.com>
Subject: [PATCH] staging: comedi: cb_pcidas64: Fixed coding style errors and an if-statement
Date: Mon, 28 May 2012 21:28:35 +0300 [thread overview]
Message-ID: <1338229715-2730-1-git-send-email-dimitrios.semitsoglou@gmail.com> (raw)
Fixed a few coding style errors and an if-statement responsible for a
sanity check inside the prep_ao_dma function.
Signed-off-by: Dimitrios Semitsoglou-Tsiapos <dimitrios.semitsoglou@gmail.com>
---
drivers/staging/comedi/drivers/cb_pcidas64.c | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcidas64.c
index 9d0b875..06cff3d 100644
--- a/drivers/staging/comedi/drivers/cb_pcidas64.c
+++ b/drivers/staging/comedi/drivers/cb_pcidas64.c
@@ -1153,12 +1153,14 @@ static int eeprom_read_insn(struct comedi_device *dev,
static void check_adc_timing(struct comedi_device *dev, struct comedi_cmd *cmd);
static unsigned int get_divisor(unsigned int ns, unsigned int flags);
static void i2c_write(struct comedi_device *dev, unsigned int address,
- const uint8_t * data, unsigned int length);
+ const uint8_t *data, unsigned int length);
static void caldac_write(struct comedi_device *dev, unsigned int channel,
unsigned int value);
static int caldac_8800_write(struct comedi_device *dev, unsigned int address,
uint8_t value);
-/* static int dac_1590_write(struct comedi_device *dev, unsigned int dac_a, unsigned int dac_b); */
+/* static int dac_1590_write(struct comedi_device *dev, unsigned int dac_a,
+ * unsigned int dac_b);
+ */
static int caldac_i2c_write(struct comedi_device *dev,
unsigned int caldac_channel, unsigned int value);
static void abort_dma(struct comedi_device *dev, unsigned int channel);
@@ -1230,7 +1232,7 @@ static unsigned int hw_revision(const struct comedi_device *dev,
}
static void set_dac_range_bits(struct comedi_device *dev,
- volatile uint16_t * bits, unsigned int channel,
+ volatile uint16_t *bits, unsigned int channel,
unsigned int range)
{
unsigned int code = board(dev)->ao_range_code[range];
@@ -3392,8 +3394,8 @@ static int prep_ao_dma(struct comedi_device *dev, const struct comedi_cmd *cmd)
num_bytes = load_ao_dma_buffer(dev, cmd);
if (num_bytes == 0)
return -1;
- if (num_bytes >= DMA_BUFFER_SIZE) ;
- load_ao_dma(dev, cmd);
+ if (num_bytes >= DMA_BUFFER_SIZE)
+ load_ao_dma(dev, cmd);
dma_start_sync(dev, 0);
@@ -4191,7 +4193,7 @@ static void i2c_stop(struct comedi_device *dev)
}
static void i2c_write(struct comedi_device *dev, unsigned int address,
- const uint8_t * data, unsigned int length)
+ const uint8_t *data, unsigned int length)
{
unsigned int i;
uint8_t bitstream;
--
1.7.10.2
next reply other threads:[~2012-05-28 18:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-28 18:28 Dimitrios Semitsoglou-Tsiapos [this message]
2012-05-28 19:31 ` richard -rw- weinberger
2012-05-28 21:51 ` [PATCH 1/2] staging: comedi: cb_pcidas64: Fixed coding style errors Dimitrios Semitsoglou-Tsiapos
2012-05-28 21:51 ` [PATCH 2/2] staging: comedi: cb_pcidas64: Fixed an if-statement check Dimitrios Semitsoglou-Tsiapos
2012-06-05 3:43 ` Greg KH
2012-06-05 8:17 ` Dimitrios Semitsoglou-Tsiapos
2012-06-05 8:31 ` Dan Carpenter
2012-05-29 6:29 ` [PATCH] staging: comedi: cb_pcidas64: Fixed coding style errors and an if-statement Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338229715-2730-1-git-send-email-dimitrios.semitsoglou@gmail.com \
--to=dimitrios.semitsoglou@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®