From: Eric Dumazet <eric.dumazet@gmail.com>
To: Devendra Naga <devendra.aaru@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Joe Perches <joe@perches.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] [staging] bcm: Replace the BCM_DEBUG_* and BCM_SHOW_* macros with functions
Date: Tue, 29 May 2012 12:06:13 +0200 [thread overview]
Message-ID: <1338285973.2840.1.camel@edumazet-glaptop> (raw)
In-Reply-To: <1338285078-17785-1-git-send-email-devendra.aaru@gmail.com>
On Tue, 2012-05-29 at 15:21 +0530, Devendra Naga wrote:
> This patch is made by following the improvements told by Joe Perches,
> replaced the BCM_DEBUG* and BCM_SHOW* macros into functions and added them
> in a file and added macros in the Debug.h file. This patch also improves the if
> check in bcm_show_debug_bitmap,
>
> the check was
> if ((i == 1) || (i == 2) || (i == 4) || (i == 8));
> anyway its a check to find whether its a power of two, and replaces
> it like the following,
> if ((i != 0) && !(i & (i - 1)))
So why not using is_power_of_2() ?
next prev parent reply other threads:[~2012-05-29 10:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-29 9:51 Devendra Naga
2012-05-29 10:06 ` Eric Dumazet [this message]
2012-05-29 10:15 ` devendra.aaru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338285973.2840.1.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=devendra.aaru@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®