From: Tomas Winkler <tomas.winkler@intel.com>
To: gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org, alan@linux.intel.com,
devel@linuxdriverproject.org,
Tomas Winkler <tomas.winkler@intel.com>
Subject: [PATCH 2/4] misc: mei: set IRQF_ONESHOT for msi request_threaded_irq
Date: Tue, 29 May 2012 16:39:10 +0300 [thread overview]
Message-ID: <1338298752-15445-3-git-send-email-tomas.winkler@intel.com> (raw)
In-Reply-To: <1338298752-15445-1-git-send-email-tomas.winkler@intel.com>
when the default irq quick handler is used then IRQF_ONESHOT must be set
otherwise the request fails and following error is displayed:
genirq: Threaded irq requested with handler=NULL and !ONESHOT for irq ...
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
---
drivers/misc/mei/main.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/misc/mei/main.c b/drivers/misc/mei/main.c
index c703332..88e5953 100644
--- a/drivers/misc/mei/main.c
+++ b/drivers/misc/mei/main.c
@@ -982,7 +982,7 @@ static int __devinit mei_probe(struct pci_dev *pdev,
err = request_threaded_irq(pdev->irq,
NULL,
mei_interrupt_thread_handler,
- 0, mei_driver_name, dev);
+ IRQF_ONESHOT, mei_driver_name, dev);
else
err = request_threaded_irq(pdev->irq,
mei_interrupt_quick_handler,
--
1.7.4.4
next prev parent reply other threads:[~2012-05-29 13:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-29 13:39 misc: mei: fixes for 3.5 Tomas Winkler
2012-05-29 13:39 ` [PATCH 1/4 V2] mei: mei.txt: minor grammar fixes Tomas Winkler
2012-05-29 13:39 ` Tomas Winkler [this message]
2012-05-29 13:39 ` [PATCH 3/4] misc: mei: unregister misc device in pci_remove function Tomas Winkler
2012-05-29 13:39 ` [PATCH 4/4] misc: mei: fix stalled read Tomas Winkler
2012-06-13 20:37 ` misc: mei: fixes for 3.5 Greg KH
2012-06-13 21:09 ` Winkler, Tomas
2012-06-13 21:45 ` Greg KH
2012-06-13 22:34 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338298752-15445-3-git-send-email-tomas.winkler@intel.com \
--to=tomas.winkler@intel.com \
--cc=alan@linux.intel.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®