From: Eric Dumazet <eric.dumazet@gmail.com>
To: Jason Wang <jasowang@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] net: sock: validate data_len before allocating skb in sock_alloc_send_pskb()
Date: Thu, 31 May 2012 08:20:32 +0200 [thread overview]
Message-ID: <1338445232.2760.1171.camel@edumazet-glaptop> (raw)
In-Reply-To: <4FC70BA8.5060200@redhat.com>
On Thu, 2012-05-31 at 14:11 +0800, Jason Wang wrote:
> Not affected, only code duplication. It's no harm the check the data_len
> again for packet sockets, so better to unify the code and fix the issue
> in one place?
As a matter of fact, we currently allocate order-0 pages, but it could
be nice trying to use order-1 or order-2 pages, on arches where
PAGE_SIZE is so small (4096 bytes)
So lets do this test in sock_alloc_send_pskb() to allow future changes.
af_unix is kind of special, because it tries to lower risk of high order
linear allocation failures. And for small sizes, it wants linear skbs to
have no performance regression (prior kernels were allocating linear
skbs)
next prev parent reply other threads:[~2012-05-31 6:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-30 5:47 Jason Wang
2012-05-30 6:46 ` Eric Dumazet
2012-05-30 7:02 ` David Miller
2012-05-31 6:00 ` Jason Wang
2012-05-31 6:02 ` Michael S. Tsirkin
2012-05-31 6:11 ` Jason Wang
2012-05-31 6:20 ` Eric Dumazet [this message]
2012-05-31 6:43 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338445232.2760.1171.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®