From: Artem Bityutskiy <dedekind1@gmail.com>
To: Joel Reardon <joel@clambassador.com>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] UBIFS: compute KSA size and store in superblock
Date: Thu, 31 May 2012 13:19:35 +0300 [thread overview]
Message-ID: <1338459575.2536.120.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1205311211340.15137@eristoteles.iwoars.net>
[-- Attachment #1: Type: text/plain, Size: 524 bytes --]
On Thu, 2012-05-31 at 12:12 +0200, Joel Reardon wrote:
> > You need to validate that:
> >
> > 1. if use_ubifsec is true, then ksa_lebs is not zero.
> > 2. ksa_lebs is sane - not too small, not too large.
> >
>
> Will add an assert and a dbg check function.
Why assert? The point is that if we read the superblock we should check
that it is sane. See teh validate_sb() function. If any of the above 2
checks fail - the superblock is insane and we should refuse mounting.
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-05-31 10:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-25 13:10 [PATCH] " Joel Reardon
2012-05-25 13:24 ` Artem Bityutskiy
2012-05-26 11:21 ` Joel Reardon
2012-05-26 13:31 ` Artem Bityutskiy
2012-05-30 13:32 ` [PATCH v2] " Joel Reardon
2012-05-30 15:18 ` Artem Bityutskiy
2012-05-31 10:12 ` Joel Reardon
2012-05-31 10:19 ` Artem Bityutskiy [this message]
2012-05-31 10:36 ` Artem Bityutskiy
2012-06-06 10:03 ` [PATCH v3] " Joel Reardon
2012-06-06 14:30 ` Artem Bityutskiy
2012-06-06 18:52 ` [PATCH v4] " Joel Reardon
2012-06-07 9:10 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338459575.2536.120.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=joel@clambassador.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome