From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: konrad@darnok.org, linux-kernel@vger.kernel.org, x86@kernel.org,
hpa@zytor.com, mingo@redhat.com, tglx@linutronix.de
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, stable@kernel.org
Subject: [PATCH] x86/i386: Check PSE bit before using PAGE_KERNEL_LARGE.
Date: Thu, 31 May 2012 15:40:18 -0400 [thread overview]
Message-ID: <1338493218-25006-1-git-send-email-konrad.wilk@oracle.com> (raw)
During bootup we would unconditionally do this on any
machine that was built with CONFIG_NUMA=y on i386:
setup_arch
\-initmem_init
\-x86_numa_init (with dummy_init as callback)
\- init_alloc_remap
\- set_pmd_pfn (with PAGE_PSE)
without checking to see if the CPU supports PSE. This
patch adds that and also allows the init_alloc_remap function
to properly work by falling back on PTEs.
CC: stable@kernel.org
Tested-by: William Dauchy <wdauchy@gmail.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
arch/x86/mm/pgtable_32.c | 25 ++++++++++++++++++++++++-
1 files changed, 24 insertions(+), 1 deletions(-)
diff --git a/arch/x86/mm/pgtable_32.c b/arch/x86/mm/pgtable_32.c
index a69bcb8..9fd4abc 100644
--- a/arch/x86/mm/pgtable_32.c
+++ b/arch/x86/mm/pgtable_32.c
@@ -86,7 +86,30 @@ void set_pmd_pfn(unsigned long vaddr, unsigned long pfn, pgprot_t flags)
}
pud = pud_offset(pgd, vaddr);
pmd = pmd_offset(pud, vaddr);
- set_pmd(pmd, pfn_pmd(pfn, flags));
+
+ if ((!cpu_has_pse) && (pgprot_val(flags) & _PAGE_PSE)) {
+ pte_t *pte;
+ int i;
+
+ pgprot_val(flags) &= ~_PAGE_PSE;
+
+ /*
+ * This is run _after_ initial memory mapped so the
+ * PTE page are allocated - but we check it just in case.
+ */
+ if (pmd_none(*pmd)) {
+ printk(KERN_WARNING "set_pmd_pfn: pmd_none\n");
+ return;
+ }
+
+ pte = (pte_t *)pmd_page_vaddr(*pmd);
+ for (i = 0; i < PTRS_PER_PTE; i++) {
+ set_pte(pte, pfn_pte(pfn + i, flags));
+ pte++;
+ }
+ } else
+ set_pmd(pmd, pfn_pmd(pfn, flags));
+
/*
* It's enough to flush this one mapping.
* (PGE mappings get flushed as well)
--
1.7.7.6
next reply other threads:[~2012-05-31 19:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-31 19:40 Konrad Rzeszutek Wilk [this message]
2012-05-31 20:21 ` H. Peter Anvin
2012-05-31 20:35 ` Konrad Rzeszutek Wilk
2012-05-31 23:02 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338493218-25006-1-git-send-email-konrad.wilk@oracle.com \
--to=konrad.wilk@oracle.com \
--cc=hpa@zytor.com \
--cc=konrad@darnok.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=stable@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®