From: Eric Dumazet <eric.dumazet@gmail.com>
To: Steven Whitehouse <swhiteho@redhat.com>
Cc: linux-kernel@vger.kernel.org, cluster-devel@redhat.com,
Al Viro <viro@zeniv.linux.org.uk>,
nstraz@redhat.com
Subject: Re: seq_file: Use larger buffer to reduce time traversing lists
Date: Fri, 01 Jun 2012 14:14:30 +0200 [thread overview]
Message-ID: <1338552870.2760.1512.camel@edumazet-glaptop> (raw)
In-Reply-To: <1338552626.2760.1510.camel@edumazet-glaptop>
On Fri, 2012-06-01 at 14:10 +0200, Eric Dumazet wrote:
> On Fri, 2012-06-01 at 11:39 +0100, Steven Whitehouse wrote:
> > I've just been taking a look at the seq_read() code, since we've noticed
> > that dumping files with large numbers of records can take some
> > considerable time. This is due to seq_read() using a buffer which, at
> > most is a single page in size, and that it has to find its place again
> > on every call to seq_read(). That makes it rather inefficient.
> >
> > As an example, I created a GFS2 filesystem with 100k inodes in it, and
> > then ran ls -l to get a decent number of cached inodes. This result in
> > there being approx 400k lines in the debugfs file containing GFS2's
> > glocks. I then timed how long it takes to read this file:
> >
> > [root@chywoon mnt]# time dd if=/sys/kernel/debug/gfs2/unity\:myfs/glocks
> > of=/dev/null bs=1M
> > 0+5769 records in
> > 0+5769 records out
> > 23273958 bytes (23 MB) copied, 63.3681 s, 367 kB/s
>
> What time do you get if you do
>
> time dd if=/sys/kernel/debug/gfs2/unity\:myfs/glocks of=/dev/null bs=4k
>
> This patch seems the wrong way to me.
>
> seq_read(size = 1MB) should perform many copy_to_user() calls instead of a single one.
>
> Instead of doing kmalloc(m->size <<= 1, GFP_KERNEL) each time we overflow the buffer,
> we should flush its content to user space.
>
>
by the way, is the following command even working ?
time dd if=/sys/kernel/debug/gfs2/unity\:myfs/glocks of=/dev/null bs=16M
I guess not, it probably returns -ENOMEM
next prev parent reply other threads:[~2012-06-01 12:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-01 10:39 Steven Whitehouse
2012-06-01 12:10 ` Eric Dumazet
2012-06-01 12:14 ` Eric Dumazet [this message]
2012-06-01 12:26 ` Steven Whitehouse
2012-06-01 12:24 ` Steven Whitehouse
2012-06-01 12:48 ` Eric Dumazet
2012-06-01 13:14 ` Steven Whitehouse
2012-06-01 13:27 ` Eric Dumazet
2012-06-01 14:18 ` Steven Whitehouse
2012-06-01 14:57 ` Eric Dumazet
2012-06-01 15:01 ` Eric Dumazet
2012-06-01 15:18 ` Eric Dumazet
2012-06-01 15:30 ` Steven Whitehouse
2012-06-01 15:28 ` Steven Whitehouse
2012-06-01 15:47 ` Eric Dumazet
2012-06-01 15:54 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338552870.2760.1512.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=cluster-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nstraz@redhat.com \
--cc=swhiteho@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®