From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
Dan Williams <dan.j.williams@gmail.com>
Subject: Re: linux-next: Tree for Jun 1 (scsi)
Date: Wed, 06 Jun 2012 14:54:13 +0900 [thread overview]
Message-ID: <1338962053.23080.7.camel@dabdike.int.hansenpartnership.com> (raw)
In-Reply-To: <4FCC2BF9.7000802@xenotime.net>
On Sun, 2012-06-03 at 20:31 -0700, Randy Dunlap wrote:
> On 05/31/2012 08:22 PM, Stephen Rothwell wrote:
>
> > Hi all,
> >
> > Changes since 20120531:
>
>
>
> already fixed?
>
> on i386 and x86_64, loadable module or builtin:
>
>
> ERROR: "scsi_sd_probe_domain" [drivers/scsi/scsi_mod.ko] undefined!
> or
> (.text+0x4f6c77): undefined reference to `scsi_sd_probe_domain'
This looks to be an obvious thinko: the symbol is conditionally
defined, but unconditionally used in
scsi_scan.c:scsi_complete_async_scans(). We can fix just by removing
the wrong conditional.
James
---
diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c
index 61c82a3..bbbc9c9 100644
--- a/drivers/scsi/scsi.c
+++ b/drivers/scsi/scsi.c
@@ -90,11 +90,9 @@ unsigned int scsi_logging_level;
EXPORT_SYMBOL(scsi_logging_level);
#endif
-#if IS_ENABLED(CONFIG_PM) || IS_ENABLED(CONFIG_BLK_DEV_SD)
-/* sd and scsi_pm need to coordinate flushing async actions */
+/* sd, scsi core and power management need to coordinate flushing async actions */
LIST_HEAD(scsi_sd_probe_domain);
EXPORT_SYMBOL(scsi_sd_probe_domain);
-#endif
/* NB: These are exposed through /proc/scsi/scsi and form part of the ABI.
* You may not alter any existing entry (although adding new ones is
next prev parent reply other threads:[~2012-06-06 5:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-01 3:22 linux-next: Tree for Jun 1 Stephen Rothwell
2012-06-04 3:31 ` linux-next: Tree for Jun 1 (scsi) Randy Dunlap
2012-06-06 5:54 ` James Bottomley [this message]
2012-06-06 21:43 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338962053.23080.7.camel@dabdike.int.hansenpartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=dan.j.williams@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®