mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Felipe Balbi <balbi@ti.com>
Cc: trivial@kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [RESEND PATCH] trivial: treewide: remove extra semicolon added by module_init/exit
Date: Wed, 06 Jun 2012 07:47:42 -0700	[thread overview]
Message-ID: <1338994062.9522.12.camel@joe2Laptop> (raw)
In-Reply-To: <1338991324-7051-1-git-send-email-balbi@ti.com>

On Wed, 2012-06-06 at 17:02 +0300, Felipe Balbi wrote:
> The definition of module_init() and module_exit()
> already added the final semicolon creating a situation
> where most of our drivers end up with two semicolons
> at the end of every module_init()/module_exit() call.
> 
> To fix that, we add missing semicolons to the places
> which didn't have them and remove the semicolons from
> the definition of module_init/module_exit.
> 
> Patch generated with the following sed script:
> 
> $ sed -i 's/^module_\(init\|exit\)\s*\((\w\+)\)$/module_\1\2;/g' \
> 	$(git ls-files)

I don't think that script works completely.
It doesn't find the module_init in fs/autofs4/init.c



  reply	other threads:[~2012-06-06 14:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-06 14:02 Felipe Balbi
2012-06-06 14:47 ` Joe Perches [this message]
2012-06-06 14:50   ` Felipe Balbi
2012-06-06 14:54   ` [PATCH v2] " Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1338994062.9522.12.camel@joe2Laptop \
    --to=joe@perches.com \
    --cc=akpm@linux-foundation.org \
    --cc=balbi@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®