From: Joe Perches <joe@perches.com>
To: Sam Hansen <solid.se7en@gmail.com>
Cc: Sam Hansen <sam@meebo-inc.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jerome Marchand <jmarchan@redhat.com>,
Nitin Gupta <ngupta@vflare.org>,
Seth Jennings <sjenning@linux.vnet.ibm.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] staging: zram: conventions, line splitting
Date: Thu, 07 Jun 2012 13:28:33 -0700 [thread overview]
Message-ID: <1339100913.14838.14.camel@joe2Laptop> (raw)
In-Reply-To: <1339100404-18773-4-git-send-email-solid.se7en@gmail.com>
On Thu, 2012-06-07 at 13:20 -0700, Sam Hansen wrote:
> Opting to violate the 80-char limit in favor of not splitting strings onto
> multiple lines (via pr_info()). This mostly to help readability.
[]
> diff --git a/drivers/staging/zram/zram_drv.c b/drivers/staging/zram/zram_drv.c
[]
> @@ -390,8 +390,7 @@ static int zram_bvec_write(struct zram *zram, struct bio_vec *bvec, u32 index,
> clen = PAGE_SIZE;
> page_store = alloc_page(GFP_NOIO | __GFP_HIGHMEM);
> if (unlikely(!page_store)) {
> - pr_info("Error allocating memory for "
> - "incompressible page: %u\n", index);
> + pr_info("Error allocating memory for incompressible page: %u\n", index);
Hi Sam.
The general use has been to allow the format string to exceed
80 columns, but not any additional arguments on the same line.
i.e. it's more conformant to use:
pr_info("Error allocating memory for incompressible page: %u\n",
index);
next prev parent reply other threads:[~2012-06-07 20:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-07 20:20 [PATCH 0/3] Styleguide conformity Sam Hansen
2012-06-07 20:20 ` [PATCH 1/3] staging: zram: conventions pr_warning -> pr_warn() Sam Hansen
2012-06-08 7:34 ` Nitin Gupta
2012-06-07 20:20 ` [PATCH 2/3] staging: zram: conventions, __aligned() attribute Sam Hansen
2012-06-08 7:37 ` Nitin Gupta
2012-06-07 20:20 ` [PATCH 3/3] staging: zram: conventions, line splitting Sam Hansen
2012-06-07 20:28 ` Joe Perches [this message]
2012-06-07 20:30 ` sam hansen
2012-06-07 23:03 ` [PATCH V2 0/3] Styleguide conformity Sam Hansen
2012-06-07 23:03 ` [PATCH V2 1/3] staging: zram: conventions pr_warning -> pr_warn() Sam Hansen
2012-06-07 23:03 ` [PATCH V2 2/3] staging: zram: conventions, __aligned() attribute Sam Hansen
2012-06-07 23:03 ` [PATCH V2 3/3] staging: zram: conventions, line splitting Sam Hansen
2012-06-08 7:42 ` Nitin Gupta
2012-06-11 16:04 ` Greg Kroah-Hartman
2012-06-11 22:08 ` Sam Hansen
2012-06-11 22:26 ` Greg Kroah-Hartman
2012-06-11 22:29 ` Sam Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339100913.14838.14.camel@joe2Laptop \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jmarchan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ngupta@vflare.org \
--cc=sam@meebo-inc.com \
--cc=sjenning@linux.vnet.ibm.com \
--cc=solid.se7en@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®