From: Suresh Siddha <suresh.b.siddha@intel.com>
To: Alexander Gordeev <agordeev@redhat.com>
Cc: Ingo Molnar <mingo@kernel.org>,
linux-kernel@vger.kernel.org, x86@kernel.org,
Yinghai Lu <yinghai@kernel.org>
Subject: Re: [PATCH] x86/apic: Eliminate cpu_mask_to_apicid() operation
Date: Fri, 08 Jun 2012 11:24:39 -0700 [thread overview]
Message-ID: <1339179879.28766.119.camel@sbsiddha-desk.sc.intel.com> (raw)
In-Reply-To: <20120608165330.GE4777@dhcp-26-207.brq.redhat.com>
On Fri, 2012-06-08 at 18:53 +0200, Alexander Gordeev wrote:
> Since there are only two locations where cpu_mask_to_apicid() is called
> from, remove the operation and use only cpu_mask_to_apicid_and() instead.
>
> Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
> ---
> arch/x86/include/asm/apic.h | 33 ++++++++-------------------------
> arch/x86/kernel/apic/apic.c | 24 ++++++------------------
> arch/x86/kernel/apic/apic_flat_64.c | 2 --
> arch/x86/kernel/apic/apic_noop.c | 1 -
> arch/x86/kernel/apic/apic_numachip.c | 1 -
> arch/x86/kernel/apic/bigsmp_32.c | 1 -
> arch/x86/kernel/apic/es7000_32.c | 4 +---
> arch/x86/kernel/apic/io_apic.c | 3 ++-
> arch/x86/kernel/apic/numaq_32.c | 8 --------
> arch/x86/kernel/apic/probe_32.c | 1 -
> arch/x86/kernel/apic/summit_32.c | 3 +--
> arch/x86/kernel/apic/x2apic_cluster.c | 17 -----------------
> arch/x86/kernel/apic/x2apic_phys.c | 1 -
> arch/x86/kernel/apic/x2apic_uv_x.c | 29 ++++++-----------------------
> arch/x86/platform/uv/uv_irq.c | 2 +-
> 15 files changed, 25 insertions(+), 105 deletions(-)
>
Looks good to me.
Acked-by: Suresh Siddha <suresh.b.siddha@intel.com>
next prev parent reply other threads:[~2012-06-08 18:25 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-05 11:23 [PATCH 4/8] x86: apic: Factor out default vector_allocation_domain() operations Alexander Gordeev
2012-06-06 8:22 ` Ingo Molnar
2012-06-06 8:42 ` Alexander Gordeev
2012-06-07 13:14 ` [PATCH 4/8] x86/apic: Factor out default vector_allocation_domain() operation Alexander Gordeev
2012-06-07 22:24 ` Suresh Siddha
2012-06-08 14:49 ` [tip:x86/apic] " tip-bot for Alexander Gordeev
2012-06-07 13:15 ` [PATCH 5/8] x86/apic: Try to spread IRQ vectors to different priority levels Alexander Gordeev
2012-06-07 22:26 ` Suresh Siddha
2012-06-08 14:50 ` [tip:x86/apic] " tip-bot for Alexander Gordeev
2012-06-20 17:23 ` H. Peter Anvin
2012-06-20 21:41 ` Suresh Siddha
2012-06-20 21:46 ` H. Peter Anvin
2012-06-07 13:15 ` [PATCH 6/8] x86/apic: Avoid useless scanning thru a cpumask in assign_irq_vector() Alexander Gordeev
2012-06-07 22:28 ` Suresh Siddha
2012-06-08 14:51 ` [tip:x86/apic] " tip-bot for Alexander Gordeev
2012-06-07 13:15 ` [PATCH 7/8] x86/apic: Make cpu_mask_to_apicid() operations return error code Alexander Gordeev
2012-06-07 22:24 ` Suresh Siddha
2012-06-08 15:15 ` Alexander Gordeev
2012-06-08 16:53 ` [PATCH] x86/apic: Eliminate cpu_mask_to_apicid() operation Alexander Gordeev
2012-06-08 18:24 ` Suresh Siddha [this message]
2012-06-08 22:36 ` Yinghai Lu
2012-06-11 8:22 ` Ingo Molnar
2012-06-11 10:51 ` Alexander Gordeev
2012-06-08 14:51 ` [tip:x86/apic] x86/apic: Make cpu_mask_to_apicid() operations return error code tip-bot for Alexander Gordeev
2012-06-07 13:16 ` [PATCH 8/8] x86/apic: Make cpu_mask_to_apicid() operations check cpu_online_mask Alexander Gordeev
2012-06-08 14:52 ` [tip:x86/apic] " tip-bot for Alexander Gordeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339179879.28766.119.camel@sbsiddha-desk.sc.intel.com \
--to=suresh.b.siddha@intel.com \
--cc=agordeev@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®