From: Daniel Santos <daniel.santos@pobox.com>
To: Richard Weinberger <richard@nod.at>
Cc: LKML <linux-kernel@vger.kernel.org>,
Daniel Santos <daniel.santos@pobox.com>
Subject: [PATCH] drivers/mtd/ubi/wl.c: optimization for in_wl_tree()
Date: Sat, 9 Jun 2012 20:57:53 -0500 [thread overview]
Message-ID: <1339293473-29444-1-git-send-email-daniel.santos@pobox.com> (raw)
Essentially, instead of performing a search through the tree from the
top down, like we would when doing a lookup, we can just search from the
node up and then check to see if the root of the tree that the node is
in is the same as the one supplied. Note that if you call this passing
a ubi_wl_entry who's u.rb member has not been inited with rb_init_node()
or added to a tree, the results are undefined.
This should be a little faster, but mostly, it'll be smaller.
---
drivers/mtd/ubi/wl.c | 32 ++++++++------------------------
1 files changed, 8 insertions(+), 24 deletions(-)
diff --git a/drivers/mtd/ubi/wl.c b/drivers/mtd/ubi/wl.c
index 9df100a..d415011 100644
--- a/drivers/mtd/ubi/wl.c
+++ b/drivers/mtd/ubi/wl.c
@@ -287,33 +287,17 @@ static int produce_free_peb(struct ubi_device *ubi)
*/
static int in_wl_tree(struct ubi_wl_entry *e, struct rb_root *root)
{
- struct rb_node *p;
-
- p = root->rb_node;
- while (p) {
- struct ubi_wl_entry *e1;
+ struct rb_node *p = &e->u.rb, *parent = rb_parent(&e->u.rb);
- e1 = rb_entry(p, struct ubi_wl_entry, u.rb);
-
- if (e->pnum == e1->pnum) {
- ubi_assert(e == e1);
- return 1;
- }
+ if (parent == p)
+ return 0;
- if (e->ec < e1->ec)
- p = p->rb_left;
- else if (e->ec > e1->ec)
- p = p->rb_right;
- else {
- ubi_assert(e->pnum != e1->pnum);
- if (e->pnum < e1->pnum)
- p = p->rb_left;
- else
- p = p->rb_right;
- }
- }
+ do {
+ p = parent;
+ parent = rb_parent(parent);
+ } while (parent);
- return 0;
+ return p == root->rb_node;
}
/**
--
1.7.3.4
next reply other threads:[~2012-06-10 1:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-10 1:57 Daniel Santos [this message]
2012-06-10 2:02 ` Daniel Santos
2012-06-10 9:58 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339293473-29444-1-git-send-email-daniel.santos@pobox.com \
--to=daniel.santos@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®