mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: Mike Frysinger <vapier@gentoo.org>
Cc: uclinux-dist-devel@blackfin.uclinux.org, linux-kernel@vger.kernel.org
Subject: blackfin: how is the I-pipe code supposed to be built?
Date: Sun, 10 Jun 2012 23:50:45 +0200	[thread overview]
Message-ID: <1339365045.30984.78.camel@x61.thuisdomein> (raw)

0) While working my way through the stack of apparently unused headers I
also looked at arch/blackfin/include/asm/ipipe_base.h, as nothing seems
to include that header. The last include of that file got removed in
commit 1353d050facf5efd8dc05ba6c4d7852fcb423b15 ("Blackfin/ipipe:
restore pipeline bits in irqflags"). So that header is unused since
v2.6.39.

1) Before submitting the (possibly trivial) patch to remove that header
I did some further research, because I wanted to be sure that removing
this header was a reasonable thing to do.

2) I learned that arch/blackfin/include/asm/ipipe_base.h got added to
the tree in commit 6a01f230339321292cf065551f8cf55361052461 ("Blackfin
arch: merge adeos blackfin part to arch/blackfin/"). That commit also
introduced the macro CONFIG_IPIPE. But it did not introduce the Kconfig
symbol IPIPE. (Neither did it add code that defines a macro
CONFIG_IPIPE.) So to me it looks like the I-pipe code got added to
v2.6.29 without proper Kbuild support.

3) And this is currently still the case. There seem to be no Kconfig
symbols IPIPE, IPIPE_DEBUG, IPIPE_DEBUG_CONTEXT, or IPIPE_TRACE_IRQSOFF.
(Neither seems there to be code that defines the macros CONFIG_IPIPE,
CONFIG_IPIPE_DEBUG, CONFIG_IPIPE_DEBUG_CONTEXT, or
CONFIG_IPIPE_TRACE_IRQSOFF.)

4) Whether or not arch/blackfin/include/asm/ipipe_base.h should be
removed isn't very interesting. What is more interesting is how the
blackfin I-pipe code is supposed to be built. How can this code be built
from what currently is in mainline?


Paul Bolle


             reply	other threads:[~2012-06-10 21:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-10 21:50 Paul Bolle [this message]
2012-06-11  3:05 ` [uclinux-dist-devel] " Zhang, Sonic
2012-06-11 19:44   ` Paul Bolle
2012-06-12  1:31     ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1339365045.30984.78.camel@x61.thuisdomein \
    --to=pebolle@tiscali.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=uclinux-dist-devel@blackfin.uclinux.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®