From: Joe Perches <joe@perches.com>
To: Don Zickus <dzickus@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
nzimmer@sgi.com, Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v3] watchdog: Quiet down the boot messages
Date: Mon, 11 Jun 2012 13:56:50 -0700 [thread overview]
Message-ID: <1339448210.19977.2.camel@joe2Laptop> (raw)
In-Reply-To: <1339445050-29941-1-git-send-email-dzickus@redhat.com>
On Mon, 2012-06-11 at 16:04 -0400, Don Zickus wrote:
> A bunch of bugzillas have complained how noisy the nmi_watchdog is during
> boot-up especially with its expected failure cases (like virt and bios
> resource contention).
[]
> diff --git a/kernel/watchdog.c b/kernel/watchdog.c
[]
> @@ -390,11 +397,23 @@ static int watchdog_nmi_enable(int cpu)
[]
> if (!IS_ERR(event)) {
> - pr_info("enabled, takes one hw-pmu counter.\n");
> + /* only print for cpu0 or different than cpu0 */
> + if (cpu == 0 || cpu0_err) {
> + pr_info("enabled on all CPUs, permanently consumes ");
> + pr_cont("one hw-PMU counter.\n");
Don't worry about formats exceeding 80 column please.
Don't break up pr_info into multiple bits either.
pr_info("enabled on all cpus, permanently consumes one hw-PMU counter\n");
next prev parent reply other threads:[~2012-06-11 20:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-11 20:04 Don Zickus
2012-06-11 20:56 ` Joe Perches [this message]
2012-06-11 21:01 ` Don Zickus
2012-06-11 21:12 ` Dave Jones
2012-06-11 21:20 ` Joe Perches
2012-06-13 7:56 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339448210.19977.2.camel@joe2Laptop \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=dzickus@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=nzimmer@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome