mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Namhyung Kim <namhyung.kim@lge.com>
Subject: [PATCH 3/3] tools lib traceevent: Introduce pevent_strerror
Date: Tue, 12 Jun 2012 16:42:39 +0900	[thread overview]
Message-ID: <1339486959-25241-4-git-send-email-namhyung@kernel.org> (raw)
In-Reply-To: <1339486959-25241-1-git-send-email-namhyung@kernel.org>

From: Namhyung Kim <namhyung.kim@lge.com>

The pevent_strerror() sets @buf to a string that describes the
(libtraceevent-specific) error condition that is passed via @errnum.

This is similar to strerror_r() and does same thing if @errnum has a
standard errno value.

Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
 tools/lib/traceevent/event-parse.c |   48 ++++++++++++++++++++++++++++++++++++
 tools/lib/traceevent/event-parse.h |    2 ++
 2 files changed, 50 insertions(+)

diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
index 866bdca4825d..3ed2d9362e69 100644
--- a/tools/lib/traceevent/event-parse.c
+++ b/tools/lib/traceevent/event-parse.c
@@ -4706,6 +4706,54 @@ enum pevent_errno pevent_parse_event(struct pevent *pevent, const char *buf,
 	return ret;
 }
 
+/*
+ * This must have a same ordering as the enum pevent_errno.
+ */
+static const char * const pevent_error_str[] = {
+	"failed to allocate memory",
+	"failed to parse event",
+	"failed to read event id",
+	"failed to read event format",
+	"failed to read event print fmt",
+	"failed to allocate field name for ftrace",
+};
+
+int pevent_strerror(struct pevent *pevent, enum pevent_errno errnum,
+		    char *buf, size_t buflen)
+{
+	int idx;
+	const char *msg;
+
+	if (errnum >= 0) {
+		strerror_r(errnum, buf, buflen);
+		return 0;
+	}
+
+	if (errnum <  __PEVENT_ERRNO__START ||
+	    errnum >= __PEVENT_ERRNO__END)
+		return -1;
+
+	idx = errnum - __PEVENT_ERRNO__START;
+	msg = pevent_error_str[idx];
+
+	switch (errnum) {
+	case PEVENT_ERRNO__MEM_ALLOC_FAILED:
+	case PEVENT_ERRNO__PARSE_EVENT_FAILED:
+	case PEVENT_ERRNO__READ_ID_FAILED:
+	case PEVENT_ERRNO__READ_FORMAT_FAILED:
+	case PEVENT_ERRNO__READ_PRINT_FAILED:
+	case PEVENT_ERRNO__OLD_FTRACE_ARG_FAILED:
+		snprintf(buf, buflen, "%s", msg);
+		break;
+
+	default:
+		/* cannot reach here */
+		break;
+	}
+
+	return 0;
+}
+
 int get_field_val(struct trace_seq *s, struct format_field *field,
 		  const char *name, struct pevent_record *record,
 		  unsigned long long *val, int err)
diff --git a/tools/lib/traceevent/event-parse.h b/tools/lib/traceevent/event-parse.h
index 24b7649d530b..7e90aba20850 100644
--- a/tools/lib/traceevent/event-parse.h
+++ b/tools/lib/traceevent/event-parse.h
@@ -576,6 +576,8 @@ int pevent_data_pid(struct pevent *pevent, struct pevent_record *rec);
 const char *pevent_data_comm_from_pid(struct pevent *pevent, int pid);
 void pevent_event_info(struct trace_seq *s, struct event_format *event,
 		       struct pevent_record *record);
+int pevent_strerror(struct pevent *pevent, enum pevent_errno errnum,
+		    char *buf, size_t buflen);
 
 struct event_format **pevent_list_events(struct pevent *pevent, enum event_sort_type);
 struct format_field **pevent_event_common_fields(struct event_format *event);
-- 
1.7.10.2


  parent reply	other threads:[~2012-06-12  7:45 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-12  7:42 [RFC PATCHSET 0/3] tools lib traceevent: Generic error handling for pevent Namhyung Kim
2012-06-12  7:42 ` [PATCH 1/3] tools lib traceevent: Do not link broken field arg for an old ftrace event Namhyung Kim
2012-06-12 17:51   ` Steven Rostedt
2012-06-12  7:42 ` [PATCH 2/3] tools lib traceevent: Introduce pevent_errno Namhyung Kim
2012-06-12 17:57   ` Steven Rostedt
2012-06-12  7:42 ` Namhyung Kim [this message]
2012-06-12 18:01   ` [PATCH 3/3] tools lib traceevent: Introduce pevent_strerror Steven Rostedt
2012-06-13  3:02     ` Namhyung Kim
2012-06-15  3:27       ` Steven Rostedt
2012-06-15  9:04         ` Namhyung Kim
2012-06-15 12:25           ` Steven Rostedt
2012-06-15 22:18             ` Namhyung Kim
2012-06-15 22:23               ` Steven Rostedt
2012-06-15 12:39   ` Steven Rostedt
2012-06-15 22:25     ` Namhyung Kim
2012-06-15 22:45       ` Steven Rostedt
2012-06-15 22:51         ` Namhyung Kim
2012-06-15 23:03           ` Steven Rostedt
2012-06-12 17:49 ` [RFC PATCHSET 0/3] tools lib traceevent: Generic error handling for pevent Steven Rostedt
2012-06-13  2:57   ` Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1339486959-25241-4-git-send-email-namhyung@kernel.org \
    --to=namhyung@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung.kim@lge.com \
    --cc=paulus@samba.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome